GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Lookahead and lookbehind by MrsMelnychenko · Pull Request #439 · javascript-tutorial/uk.javascript.info

Conversation

MrsMelnychenko commented Jan 6, 2023

Copy link

Copy Markdown

Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

MrsMelnychenko added 9 commits

January 6, 2023 18:53


          Update article.md

fd901d2


          Update solution.md

214ce99


          Update task.md

2a6c660


          Update solution.md

b72a022


          Update task.md

e43cb3b


          Update solution.md

f810283


          Update task.md

1cbe619


          Update task.md


          Update solution.md

6d90c0f

javascript-translate-bot added the review needed label

Jan 6, 2023

javascript-translate-bot mentioned this pull request

Jan 6, 2023

Ukrainian Translation Progress #1

Open

dolgachio requested changes

Mar 12, 2023

View reviewed changes

dolgachio left a comment

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Дякую, за ваш внесок! Вибачаюсь, що так довго перевіряв.
Я сам внесу всі необхідні зміни і прийму ваш пулл реквест

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

9-regular-expressions/14-regexp-lookahead-lookbehind/1-find-non-negative-integers/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

9-regular-expressions/14-regexp-lookahead-lookbehind/1-find-non-negative-integers/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

9-regular-expressions/14-regexp-lookahead-lookbehind/1-find-non-negative-integers/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

9-regular-expressions/14-regexp-lookahead-lookbehind/1-find-non-negative-integers/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

9-regular-expressions/14-regexp-lookahead-lookbehind/1-find-non-negative-integers/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

9-regular-expressions/14-regexp-lookahead-lookbehind/article.md Outdated

		Пам'ятайте, `str.match` (без флажку `pattern:g`) і `str.matchAll` (всі) повертає співпадіння у вигляді масиву з властивістю `індекс`, тож ми точно знаємо де саме в тексті вони знаходяться і можемо перевірити контекст.

		But generally lookaround is more convenient.
		Але загалом перегляд уперед і назад більш підходящі.

dolgachio Mar 12, 2023

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

	Але загалом перегляд уперед і назад більш підходящі.
	Але загалом перевірка уперед і назад більш підходящі.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

9-regular-expressions/14-regexp-lookahead-lookbehind/article.md Outdated

		\| `X(?!Y)` \| Negative lookahead \| `pattern:X` if not followed by `pattern:Y` \|
		\| `(?<=Y)X` \| Positive lookbehind \| `pattern:X` if after `pattern:Y` \|
		\| `(?<!Y)X` \| Negative lookbehind \| `pattern:X` if not after `pattern:Y` \|
		\| `X(?=Y)` \| Позитивний перегляд уперед \| `pattern:X` якщо за ним йде `pattern:Y` \|

dolgachio Mar 12, 2023

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

	\| `X(?=Y)` \| Позитивний перегляд уперед \| `pattern:X` якщо за ним йде `pattern:Y` \|
	\| `X(?=Y)` \| Позитивна перевірка уперед \| `pattern:X` якщо за ним йде `pattern:Y` \|

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

9-regular-expressions/14-regexp-lookahead-lookbehind/article.md Outdated

		\| `(?<=Y)X` \| Positive lookbehind \| `pattern:X` if after `pattern:Y` \|
		\| `(?<!Y)X` \| Negative lookbehind \| `pattern:X` if not after `pattern:Y` \|
		\| `X(?=Y)` \| Позитивний перегляд уперед \| `pattern:X` якщо за ним йде `pattern:Y` \|
		\| `X(?!Y)` \| Негативний перегляд уперед \| `pattern:X` якщо за ним не йде `pattern:Y` \|

dolgachio Mar 12, 2023

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

	\| `X(?!Y)` \| Негативний перегляд уперед \| `pattern:X` якщо за ним не йде `pattern:Y` \|
	\| `X(?!Y)` \| Негативна перевірка уперед \| `pattern:X` якщо за ним не йде `pattern:Y` \|

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

9-regular-expressions/14-regexp-lookahead-lookbehind/article.md Outdated

		\| `(?<!Y)X` \| Negative lookbehind \| `pattern:X` if not after `pattern:Y` \|
		\| `X(?=Y)` \| Позитивний перегляд уперед \| `pattern:X` якщо за ним йде `pattern:Y` \|
		\| `X(?!Y)` \| Негативний перегляд уперед \| `pattern:X` якщо за ним не йде `pattern:Y` \|
		\| `(?<=Y)X` \| Позитивний перегляд назад \| `pattern:X` якщо він йде після `pattern:Y` \|

dolgachio Mar 12, 2023

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

	\| `(?<=Y)X` \| Позитивний перегляд назад \| `pattern:X` якщо він йде після `pattern:Y` \|
	\| `(?<=Y)X` \| Позитивна перевірка назад \| `pattern:X` якщо він йде після `pattern:Y` \|

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

9-regular-expressions/14-regexp-lookahead-lookbehind/article.md Outdated

		\| `X(?=Y)` \| Позитивний перегляд уперед \| `pattern:X` якщо за ним йде `pattern:Y` \|
		\| `X(?!Y)` \| Негативний перегляд уперед \| `pattern:X` якщо за ним не йде `pattern:Y` \|
		\| `(?<=Y)X` \| Позитивний перегляд назад \| `pattern:X` якщо він йде після `pattern:Y` \|
		\| `(?<!Y)X` \| Негативний перегляд назад \| `pattern:X` якщо тільки він не йде після `pattern:Y` \|

dolgachio Mar 12, 2023

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

	\| `(?<!Y)X` \| Негативний перегляд назад \| `pattern:X` якщо тільки він не йде після `pattern:Y` \|
	\| `(?<!Y)X` \| Негативна перевірка назад \| `pattern:X` якщо тільки він не йде після `pattern:Y` \|

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

javascript-translate-bot removed the review needed label

Mar 12, 2023

javascript-translate-bot commented Mar 12, 2023

Copy link

Copy Markdown

Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added the changes requested label

Mar 12, 2023

dolgachio added 2 commits

March 12, 2023 21:28


          Apply suggestions from code review

e239faa


          Apply suggestions from code review

084e6f0

dolgachio approved these changes

Mar 12, 2023

View reviewed changes

javascript-translate-bot added needs +1 and removed changes requested labels

Mar 12, 2023

dolgachio commented Mar 12, 2023

Copy link

Copy Markdown

Collaborator

@all-contributors add @MrsMelnychenko for translation

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

allcontributors Bot commented Mar 12, 2023

Copy link

Copy Markdown

Contributor

@stas-dolgachov

@MrsMelnychenko already contributed before to translation

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

dolgachio merged commit 27c494f into javascript-tutorial:master

Mar 12, 2023

javascript-translate-bot commented Mar 12, 2023

Copy link

Copy Markdown

Contributor

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

dolgachio

dolgachio approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.