GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Capturing groups by SamGreenberg · Pull Request #441 · javascript-tutorial/uk.javascript.info

Conversation

@SamGreenberg

@SamGreenberg SamGreenberg commented Jan 11, 2023

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@SamGreenberg
Capturing groups
763042b
@javascript-translate-bot javascript-translate-bot added the review needed label Jan 11, 2023
@javascript-translate-bot javascript-translate-bot mentioned this pull request Jan 11, 2023
Ukrainian Translation Progress #1
Open
dolgachio
dolgachio requested changes Mar 25, 2023
View reviewed changes

@dolgachio dolgachio left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Дякую за переклад і ваш внесок! Я додав кілька коментарів до тексту, з вашого боку нічого більше не треба, я сам внесу необхідні зміни

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 9-regular-expressions/11-regexp-groups/01-test-mac/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 9-regular-expressions/11-regexp-groups/01-test-mac/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 9-regular-expressions/11-regexp-groups/01-test-mac/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 9-regular-expressions/11-regexp-groups/02-find-webcolor-3-or-6/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 9-regular-expressions/11-regexp-groups/02-find-webcolor-3-or-6/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 9-regular-expressions/11-regexp-groups/article.md Outdated

```js run
let str = "Gogogo John!";
let str = "Gogogo Іван!";

@dolgachio dolgachio Mar 25, 2023

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
let str = "Gogogo Іван!";
let str = "Gogogo John!";

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 9-regular-expressions/11-regexp-groups/article.md Outdated
alert( result[0] ); // Gogogo John (full match)
alert( result[1] ); // John
alert( result.length ); // 2 (no more items in the array)
alert( result[0] ); // Gogogo Іван (повний збіг)

@dolgachio dolgachio Mar 25, 2023

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
alert( result[0] ); // Gogogo Іван (повний збіг)
alert( result[0] ); // Gogogo John (повний збіг)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 9-regular-expressions/11-regexp-groups/article.md Outdated
alert( result[1] ); // John
alert( result.length ); // 2 (no more items in the array)
alert( result[0] ); // Gogogo Іван (повний збіг)
alert( result[1] ); // Іван

@dolgachio dolgachio Mar 25, 2023

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
alert( result[1] ); // Іван
alert( result[1] ); // John

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 9-regular-expressions/11-regexp-groups/article.md Outdated
alert( result.length ); // 2 (no more items in the array)
alert( result[0] ); // Gogogo Іван (повний збіг)
alert( result[1] ); // Іван
alert( result.length ); // 2 (інших елементів у масиві нема)

@dolgachio dolgachio Mar 25, 2023

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
alert( result.length ); // 2 (інших елементів у масиві нема)
alert( result.length ); // 2 (інших елементів у масиві немає)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 9-regular-expressions/11-regexp-groups/article.md Outdated

- The method `str.match` returns capturing groups only without flag `pattern:g`.
- The method `str.matchAll` always returns capturing groups.
- Метод `str.match` повертає групи захоплення лише без прапору `pattern:g`.

@dolgachio dolgachio Mar 25, 2023

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Метод `str.match` повертає групи захоплення лише без прапору `pattern:g`.
- Метод `str.match` повертає групи захоплення лише без прапорцю `pattern:g`.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@javascript-translate-bot javascript-translate-bot added changes requested and removed review needed labels Mar 25, 2023
@javascript-translate-bot

javascript-translate-bot commented Mar 25, 2023

Copy link
Copy Markdown
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dolgachio
Apply suggestions from code review
00907f2
dolgachio
dolgachio approved these changes Mar 25, 2023
View reviewed changes
@javascript-translate-bot javascript-translate-bot added needs +1 and removed changes requested labels Mar 25, 2023
@dolgachio

dolgachio commented Mar 25, 2023

Copy link
Copy Markdown
Collaborator

@all-contributors add @SamGreenberg for translation
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@allcontributors

allcontributors Bot commented Mar 25, 2023

Copy link
Copy Markdown
Contributor

@stas-dolgachov

@SamGreenberg already contributed before to translation
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dolgachio
dolgachio merged commit 0dc4838 into javascript-tutorial:master Mar 25, 2023
@javascript-translate-bot

javascript-translate-bot commented Mar 25, 2023

Copy link
Copy Markdown
Contributor

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dolgachio dolgachio dolgachio approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@SamGreenberg @javascript-translate-bot @dolgachio
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.