GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Methods of RegExp and String by SamGreenberg · Pull Request #445 · javascript-tutorial/uk.javascript.info

Conversation

@SamGreenberg

@SamGreenberg SamGreenberg commented Jan 22, 2023

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@SamGreenberg
Methods of RegExp and String
759176b
@javascript-translate-bot javascript-translate-bot added the review needed label Jan 22, 2023
@javascript-translate-bot javascript-translate-bot mentioned this pull request Jan 22, 2023
Ukrainian Translation Progress #1
Open
RiinaVi
RiinaVi reviewed Feb 7, 2023
View reviewed changes
Comment thread 9-regular-expressions/17-regexp-methods/article.md Outdated
````warn header="Same global regexp tested repeatedly on different sources may fail"
If we apply the same global regexp to different inputs, it may lead to wrong result, because `regexp.test` call advances `regexp.lastIndex` property, so the search in another string may start from non-zero position.
````warn header="Один і той самий глобальний регулярний вираз, протестований багато разів на різних даних, може помилятись"
Якщо ми застосуємо один і той самий глобальний регулярний вираз до різних вхідних даних, можемо отримати неправильні результати, бо виклик `regexp.test` посуває властивість `regexp.lastIndex`, тож пошук в іншому рядку може початись з позиції, відмінною від нуля.

@RiinaVi RiinaVi Feb 7, 2023

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"відмінної"? позиції якої? - "відмінної"

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
SamGreenberg and tarasyyyk reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@SamGreenberg
fix
f49b711
tarasyyyk
tarasyyyk approved these changes May 24, 2023
View reviewed changes
@javascript-translate-bot javascript-translate-bot added needs +1 and removed review needed labels May 24, 2023
@tarasyyyk
tarasyyyk merged commit 67130e0 into javascript-tutorial:master May 24, 2023
@javascript-translate-bot

javascript-translate-bot commented May 24, 2023

Copy link
Copy Markdown
Contributor

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarasyyyk tarasyyyk tarasyyyk approved these changes
+1 more reviewer
@RiinaVi RiinaVi RiinaVi left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@SamGreenberg @javascript-translate-bot @tarasyyyk @RiinaVi
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.