GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Coding style by alexgalkin · Pull Request #59 · javascript-tutorial/uk.javascript.info

Conversation

alexgalkin commented Feb 26, 2020

Copy link

Copy Markdown

Contributor

Another attempt to prepare PR for translation (as mentioned previously SVG will be changed using YAML file later). Please review and comment.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Translate Code Style section

c0db2c2

javascript-translate-bot added the review needed label

Feb 26, 2020

javascript-translate-bot requested a review from a team

February 26, 2020 01:42


          Fixed mistake in solution translation

48299ae

tarasyyyk requested changes

Feb 26, 2020

View reviewed changes

tarasyyyk left a comment

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good translation!
Please, made small corrections and I'll merge this PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/03-code-quality/02-coding-style/article.md Outdated

		# Стандарт оформлення коду

		Our code must be as clean and easy to read as possible.
		Наш код повинен бути настільки чистим та зрозумілим наскільки це можливо.

tarasyyyk Feb 26, 2020

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

«настільки зрозумілим та читабельним, наскільки це можливо»

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/03-code-quality/02-coding-style/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/03-code-quality/02-coding-style/article.md Outdated

		-->

		Now let's discuss the rules and reasons for them in detail.
		Давайте розберемо ці правила і причини їх з'явлення більш детально.

tarasyyyk Feb 26, 2020

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

«Давайте детальніше розглянемо ці правила і причини їх появи»

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/03-code-quality/02-coding-style/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/03-code-quality/02-coding-style/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/03-code-quality/02-coding-style/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/03-code-quality/02-coding-style/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/03-code-quality/02-coding-style/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/03-code-quality/02-coding-style/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/03-code-quality/02-coding-style/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added changes requested and removed review needed labels

Feb 26, 2020

javascript-translate-bot commented Feb 26, 2020

Copy link

Copy Markdown

Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

alexgalkin and others added 10 commits

February 27, 2020 00:14


          Update 1-js/03-code-quality/02-coding-style/article.md

593e2e1

Co-Authored-By: Taras <[email protected]>


          Update 1-js/03-code-quality/02-coding-style/article.md

b719b94

Co-Authored-By: Taras <[email protected]>


          Update 1-js/03-code-quality/02-coding-style/article.md

3f363f2

Co-Authored-By: Taras <[email protected]>


          Fix minor typos and mistakes

f6ea17d


          Merge branch 'master' of github.com:alexgalkin/uk.javascript.info

466d476


          Fix minor typos and mistakes

4f4e0cb


          Update 1-js/03-code-quality/02-coding-style/article.md

d8bd044

Co-Authored-By: Taras <[email protected]>


          Update 1-js/03-code-quality/02-coding-style/article.md

aa0e0ce

Co-Authored-By: Taras <[email protected]>


          Update 1-js/03-code-quality/02-coding-style/article.md

74d9c97

Co-Authored-By: Taras <[email protected]>


          Fix mistakes according to the review

11aaeb4

alexgalkin requested a review from tarasyyyk

February 26, 2020 22:45

alexgalkin commented Feb 26, 2020

Copy link

Copy Markdown

Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

Feb 26, 2020

javascript-translate-bot requested a review from a team

February 26, 2020 22:45

alexgalkin and others added 7 commits

February 27, 2020 00:48


          one more minor correction

0998cd2


          Translate Code Style section

ee977f1


          Fixed mistake in solution translation

f3b11a3


          Update 1-js/03-code-quality/02-coding-style/article.md

cbcfd03

Co-Authored-By: Taras <[email protected]>


          Update 1-js/03-code-quality/02-coding-style/article.md

edc13e6

Co-Authored-By: Taras <[email protected]>


          Fix minor typos and mistakes

f2c65f6


          Update 1-js/03-code-quality/02-coding-style/article.md

9684e5d

Co-Authored-By: Taras <[email protected]>

alexgalkin and others added 7 commits

February 27, 2020 00:51


          Fix minor typos and mistakes

0ba48b6


          Update 1-js/03-code-quality/02-coding-style/article.md

d4269aa

Co-Authored-By: Taras <[email protected]>


          Update 1-js/03-code-quality/02-coding-style/article.md

33bf37f

Co-Authored-By: Taras <[email protected]>


          Update 1-js/03-code-quality/02-coding-style/article.md

Co-Authored-By: Taras <[email protected]>


          Fix mistakes according to the review

5b3d4c0


          one more minor correction


          Merge branch 'master' of github.com:alexgalkin/uk.javascript.info

d6a4af5

tarasyyyk requested changes

Feb 27, 2020

View reviewed changes

tarasyyyk left a comment

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last small correction need to be fixed before merge.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/03-code-quality/02-coding-style/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added changes requested and removed review needed labels

Feb 27, 2020

javascript-translate-bot commented Feb 27, 2020

Copy link

Copy Markdown

Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          minor fix

cdd5a3a

alexgalkin requested a review from tarasyyyk

February 27, 2020 18:37

tarasyyyk approved these changes

Feb 27, 2020

View reviewed changes

tarasyyyk left a comment

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Thank you for contribution!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

javascript-translate-bot added needs +1 and removed changes requested labels

Feb 27, 2020

tarasyyyk merged commit c792b67 into javascript-tutorial:master

Feb 27, 2020

iliakan mentioned this pull request

Feb 27, 2020

Ukrainian Translation Progress #1

Open

tarasyyyk removed the needs +1 label

Mar 6, 2020

tarasyyyk changed the title ~~Translate Code Style section~~ Coding style

Aug 29, 2024

Reviewers

tarasyyyk

tarasyyyk approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.