GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Comments by alexgalkin · Pull Request #60 · javascript-tutorial/uk.javascript.info

Conversation

@alexgalkin

@alexgalkin alexgalkin commented Feb 28, 2020

Copy link
Copy Markdown
Contributor

Translation of the "Comments" section.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
alexgalkin and others added 6 commits February 27, 2020 21:16
@alexgalkin
Start translation of the Comments section
7da2050
@alexgalkin
continue translating comments
2af7451
@alexgalkin
Corrected formatting - there were useless spaces
4737f15
@alexgalkin
Finish translation of the Comments; minor fixes
0e115ee
@alexgalkin
Merge remote-tracking branch 'upstream/master' into translation/comments
94ed238
@alexgalkin
minor update: removed space
519fe02
@javascript-translate-bot javascript-translate-bot added the review needed label Feb 28, 2020
@javascript-translate-bot
javascript-translate-bot requested a review from a team February 28, 2020 21:12
tarasyyyk
tarasyyyk requested changes Feb 29, 2020
View reviewed changes

@tarasyyyk tarasyyyk left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small corrections

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 1-js/03-code-quality/03-comments/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/03-code-quality/03-comments/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/03-code-quality/03-comments/article.md Outdated

*!*
// check if i is a prime number
// перевірка чи є i простим числом

@tarasyyyk tarasyyyk Feb 29, 2020

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// перевірка чи є i простим числом
// перевірка чи є 'i' простим числом

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 1-js/03-code-quality/03-comments/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/03-code-quality/03-comments/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/03-code-quality/03-comments/article.md
}
```
Наприклад:

@tarasyyyk tarasyyyk Feb 29, 2020

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove extra space.
It's better to add this one to English version as PR and this will be merged into Ukrainian if approved.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@alexgalkin alexgalkin Feb 29, 2020

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created separate PR javascript-tutorial/en.javascript.info#1780 for this in English version

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tarasyyyk reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Comment thread 1-js/03-code-quality/03-comments/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/03-code-quality/03-comments/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/03-code-quality/03-comments/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@javascript-translate-bot javascript-translate-bot removed the review needed label Feb 29, 2020
@javascript-translate-bot

javascript-translate-bot commented Feb 29, 2020

Copy link
Copy Markdown
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@javascript-translate-bot javascript-translate-bot added the changes requested label Feb 29, 2020
@iliakan iliakan mentioned this pull request Feb 29, 2020
Ukrainian Translation Progress #1
Open
alexgalkin and others added 8 commits February 29, 2020 22:48
@alexgalkin @tarasyyyk
Update 1-js/03-code-quality/03-comments/article.md
8ef3e3a 
Co-Authored-By: Taras <[email protected]>
@alexgalkin @tarasyyyk
Update 1-js/03-code-quality/03-comments/article.md
49c4109 
Co-Authored-By: Taras <[email protected]>
@alexgalkin @tarasyyyk
Update 1-js/03-code-quality/03-comments/article.md
0f5d422 
Co-Authored-By: Taras <[email protected]>
@alexgalkin @tarasyyyk
Update 1-js/03-code-quality/03-comments/article.md
379d44a 
Co-Authored-By: Taras <[email protected]>
@alexgalkin @tarasyyyk
Update 1-js/03-code-quality/03-comments/article.md
6630148 
Co-Authored-By: Taras <[email protected]>
@alexgalkin @tarasyyyk
Update 1-js/03-code-quality/03-comments/article.md
bcdc3d1 
Co-Authored-By: Taras <[email protected]>
@alexgalkin @tarasyyyk
Update 1-js/03-code-quality/03-comments/article.md
68ca202 
Co-Authored-By: Taras <[email protected]>
@alexgalkin
Small correction to variable i ref
e731e5a
@alexgalkin

alexgalkin commented Feb 29, 2020

Copy link
Copy Markdown
Contributor Author

/done
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@javascript-translate-bot javascript-translate-bot added review needed and removed changes requested labels Feb 29, 2020
@javascript-translate-bot
javascript-translate-bot requested a review from a team February 29, 2020 21:00
@alexgalkin
alexgalkin requested review from tarasyyyk and removed request for a team February 29, 2020 21:00
@tarasyyyk
tarasyyyk merged commit aabd08b into javascript-tutorial:master Feb 29, 2020
@tarasyyyk tarasyyyk removed the review needed label Mar 6, 2020
@tarasyyyk tarasyyyk changed the title Translation of "Comments" section Comments Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarasyyyk tarasyyyk Awaiting requested review from tarasyyyk

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@alexgalkin @javascript-translate-bot @tarasyyyk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.