GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Numbers by alexandrtovmach · Pull Request #62 · javascript-tutorial/uk.javascript.info

Conversation

alexandrtovmach commented Mar 5, 2020

Copy link

Copy Markdown

Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          feat: Completed half of article translation

2206ccf

javascript-translate-bot added the review needed label

Mar 5, 2020

javascript-translate-bot requested a review from a team

March 5, 2020 09:32

CLAassistant commented Mar 5, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

All committers have signed the CLA.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

tarasyyyk reviewed

Mar 5, 2020

View reviewed changes

tarasyyyk left a comment

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very correct translation! No typos at all.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

alexandrtovmach and alexgalkin reacted with thumbs up emoji

All reactions

👍 2 reactions

Comment thread

1-js/05-data-types/02-number/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/02-number/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Apply suggestions from code review

92fc77f

Co-Authored-By: Taras <[email protected]>

alexgalkin reviewed

Mar 6, 2020

View reviewed changes

Comment thread

1-js/05-data-types/02-number/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

alexgalkin reviewed

Mar 6, 2020

View reviewed changes

alexgalkin left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Чудовий початок!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

alexandrtovmach added 3 commits

March 6, 2020 11:57


          feat: Completed article translation

d669861


          feat: Completed tasks translation

d94a3e3


          Merge branch 'translation/js-dataTypes-number' of github.com:alexandr…

c8d550d

…tovmach/uk.javascript.info into translation/js-dataTypes-number

alexandrtovmach marked this pull request as ready for review

March 6, 2020 10:41

alexandrtovmach commented Mar 6, 2020

Copy link

Copy Markdown

Contributor Author

@tarasyyyk @alexgalkin
переклад завершено, можна ревьювити та мерджити

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

tarasyyyk requested changes

Mar 6, 2020

View reviewed changes

tarasyyyk left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Впринципі, немає помилок в перекладі. Можна мерджити, але є деякі зауваження.
@alexgalkin гляньте «незамилиним» оком на мої виправлення, чи згідні ви з ними.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/05-data-types/02-number/1-sum-interface/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/02-number/2-why-rounded-down/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/02-number/2-why-rounded-down/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/02-number/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot removed the review needed label

Mar 6, 2020

javascript-translate-bot commented Mar 6, 2020

Copy link

Copy Markdown

Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added the changes requested label

Mar 6, 2020

iliakan mentioned this pull request

Mar 6, 2020

Ukrainian Translation Progress #1

Open


          Apply suggestions from code review

49766ed

Co-Authored-By: Taras <[email protected]>

alexandrtovmach requested a review from tarasyyyk

March 6, 2020 19:47

alexandrtovmach commented Mar 6, 2020

Copy link

Copy Markdown

Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

Mar 6, 2020

javascript-translate-bot requested a review from a team

March 6, 2020 19:47

tarasyyyk approved these changes

Mar 6, 2020

View reviewed changes

javascript-translate-bot added needs +1 and removed review needed labels

Mar 6, 2020

tarasyyyk merged commit 796b2b4 into javascript-tutorial:master

Mar 6, 2020

alexandrtovmach deleted the translation/js-dataTypes-number branch

March 6, 2020 20:45

tarasyyyk commented Mar 6, 2020

Copy link

Copy Markdown

Collaborator

Thanks for your contribution! @all-contributors please add @alexandrtovmach to list for translation.

alexandrtovmach reacted with hooray emoji

All reactions

🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

allcontributors Bot mentioned this pull request

Mar 6, 2020

docs: add alexandrtovmach as a contributor #64

Merged

allcontributors Bot commented Mar 6, 2020

Copy link

Copy Markdown

Contributor

@tarasyyyk

I've put up a pull request to add @alexandrtovmach! 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

alexgalkin commented Mar 6, 2020

Copy link

Copy Markdown

Contributor

@alexandrtovmach amazing example of translation. Thanks for your contribution!

alexandrtovmach reacted with thumbs up emoji

Gam3356 reacted with hooray emoji

All reactions

👍 1 reaction
🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

tarasyyyk removed the needs +1 label

Mar 6, 2020

tarasyyyk changed the title ~~Translation for js-dataTypes-number~~ Numbers

Aug 29, 2024

Reviewers

tarasyyyk

tarasyyyk approved these changes

+1 more reviewer

alexgalkin

alexgalkin left review comments

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

alexandrtovmach commented Mar 5, 2020

Uh oh!

CLAassistant commented Mar 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tarasyyyk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alexgalkin left a comment

Choose a reason for hiding this comment

Uh oh!

alexandrtovmach commented Mar 6, 2020

Uh oh!

tarasyyyk left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Mar 6, 2020

Uh oh!

alexandrtovmach commented Mar 6, 2020

Uh oh!

tarasyyyk commented Mar 6, 2020

Uh oh!

allcontributors Bot commented Mar 6, 2020

Uh oh!

alexgalkin commented Mar 6, 2020

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

CLAassistant commented Mar 5, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

tarasyyyk left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.