GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Coding Style by ImVietnam · Pull Request #174 · javascript-tutorial/vi.javascript.info

Conversation

ImVietnam commented Feb 21, 2023

Copy link

Copy Markdown

Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Update article.md

9bad668

javascript-translate-bot added the review needed label

Feb 21, 2023

javascript-translate-bot requested a review from a team

February 21, 2023 14:47

javascript-translate-bot mentioned this pull request

Feb 21, 2023

Vietnamese Translation Progress #1

Open

ImVietnam added 14 commits

February 22, 2023 09:58


          Update code-style.svg

73b0c53


          Update code-style.svg

8e42191


          Update code-style.svg

25c1521


          Update code-style.svg

f1a0a9d


          Update code-style.svg

e5e830a


          Update code-style.svg


          Update code-style.svg

fa1734b


          Update code-style.svg


          Update code-style.svg

185584c


          Merge pull request #2 from ImVietnam/patch-4

6e7a504

Patch 4


          Update article.md

631b353


          Update task.md

b44d40c


          Update solution.md

e6080c4


          Merge pull request #3 from ImVietnam/patch-4

ab3fc90

Patch 4

henryonsoftware suggested changes

Feb 23, 2023

View reviewed changes

Comment thread

1-js/03-code-quality/02-coding-style/1-style-errors/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/03-code-quality/02-coding-style/1-style-errors/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/03-code-quality/02-coding-style/1-style-errors/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/03-code-quality/02-coding-style/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/03-code-quality/02-coding-style/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/03-code-quality/02-coding-style/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/03-code-quality/02-coding-style/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/03-code-quality/02-coding-style/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/03-code-quality/02-coding-style/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/03-code-quality/02-coding-style/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added changes requested and removed review needed labels

Feb 23, 2023

javascript-translate-bot commented Feb 23, 2023

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ImVietnam added 3 commits

February 25, 2023 13:03


          Update solution.md

7787c62


          Update task.md

1375bf1


          Update article.md

7da2573

ImVietnam commented Feb 25, 2023

Copy link

Copy Markdown

Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

Feb 25, 2023

javascript-translate-bot requested a review from a team

February 25, 2023 06:20

henryonsoftware removed the review needed label

Feb 28, 2023

henryonsoftware added the changes requested label

Feb 28, 2023


          Update article.md

87d1b13

ImVietnam commented Mar 1, 2023

Copy link

Copy Markdown

Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

Mar 1, 2023

henryonsoftware approved these changes

Mar 1, 2023

View reviewed changes

henryonsoftware left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

javascript-translate-bot added needs +1 and removed review needed labels

Mar 1, 2023

henryonsoftware requested a review from tunggnu

March 1, 2023 19:25


          Merge branch 'javascript-tutorial:master' into patch-2

6c7aaae

tunggnu requested changes

Jun 8, 2023

View reviewed changes

Comment thread

1-js/03-code-quality/02-coding-style/1-style-errors/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/03-code-quality/02-coding-style/1-style-errors/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/03-code-quality/02-coding-style/1-style-errors/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/03-code-quality/02-coding-style/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/03-code-quality/02-coding-style/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/03-code-quality/02-coding-style/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/03-code-quality/02-coding-style/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/03-code-quality/02-coding-style/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/03-code-quality/02-coding-style/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/03-code-quality/02-coding-style/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added the changes requested label

Jun 8, 2023

javascript-translate-bot commented Jun 8, 2023

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ImVietnam added 4 commits

June 8, 2023 12:26


          Update solution.md

b41d273


          Update task.md

b05925b


          Update article.md

1b00f35


          Update article.md

3b73fe3

ImVietnam commented Jun 8, 2023

Copy link

Copy Markdown

Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

Jun 8, 2023

javascript-translate-bot requested a review from a team

June 8, 2023 05:30


          Merge branch 'javascript-tutorial:master' into patch-2

917bbe5

tunggnu approved these changes

Jun 8, 2023

View reviewed changes

tunggnu left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

tunggnu merged commit 94a73bd into javascript-tutorial:master

Jun 8, 2023

javascript-translate-bot commented Jun 8, 2023

Copy link

Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

tunggnu

tunggnu approved these changes

+1 more reviewer

henryonsoftware

henryonsoftware approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1 review needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.