GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Ninja code by ImVietnam · Pull Request #175 · javascript-tutorial/vi.javascript.info

Conversation

@ImVietnam

@ImVietnam ImVietnam commented Feb 21, 2023

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ImVietnam
Update article.md
47dd350
@javascript-translate-bot javascript-translate-bot added the review needed label Feb 21, 2023
@javascript-translate-bot
javascript-translate-bot requested a review from a team February 21, 2023 15:26
@javascript-translate-bot javascript-translate-bot mentioned this pull request Feb 21, 2023
Vietnamese Translation Progress #1
Open
ImVietnam added 2 commits February 22, 2023 10:53
@ImVietnam
Update article.md
1b0ee71
@ImVietnam
Update article.md
ec62f38
henryonsoftware
henryonsoftware reviewed Feb 23, 2023
View reviewed changes
Comment thread 1-js/03-code-quality/04-ninja-code/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/03-code-quality/04-ninja-code/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/03-code-quality/04-ninja-code/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/03-code-quality/04-ninja-code/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/03-code-quality/04-ninja-code/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/03-code-quality/04-ninja-code/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/03-code-quality/04-ninja-code/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/03-code-quality/04-ninja-code/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/03-code-quality/04-ninja-code/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
tunggnu
tunggnu requested changes Feb 27, 2023
View reviewed changes

@tunggnu tunggnu left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ImVietnam bạn xem lại các nhận xét và cập nhật lại bản dịch nhé.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@javascript-translate-bot javascript-translate-bot added changes requested and removed review needed labels Feb 27, 2023
@javascript-translate-bot

javascript-translate-bot commented Feb 27, 2023

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ImVietnam
Update article.md
b15db26
@ImVietnam

ImVietnam commented Feb 28, 2023

Copy link
Copy Markdown
Contributor Author

/done
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@javascript-translate-bot javascript-translate-bot added review needed and removed changes requested labels Feb 28, 2023
@javascript-translate-bot
javascript-translate-bot requested a review from a team February 28, 2023 04:17
tunggnu
tunggnu approved these changes Feb 28, 2023
View reviewed changes

@tunggnu tunggnu left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@javascript-translate-bot javascript-translate-bot added needs +1 and removed review needed labels Feb 28, 2023
@ImVietnam

ImVietnam commented Feb 28, 2023

Copy link
Copy Markdown
Contributor Author

thx
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
henryonsoftware
henryonsoftware approved these changes Feb 28, 2023
View reviewed changes

@henryonsoftware henryonsoftware left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@henryonsoftware
henryonsoftware merged commit f604507 into javascript-tutorial:master Feb 28, 2023
@javascript-translate-bot

javascript-translate-bot commented Feb 28, 2023

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ImVietnam
ImVietnam deleted the patch-3 branch March 1, 2023 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tunggnu tunggnu tunggnu approved these changes
+1 more reviewer
@henryonsoftware henryonsoftware henryonsoftware approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@ImVietnam @javascript-translate-bot @tunggnu @henryonsoftware
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.