GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Manuals and specifications by tom76kimo · Pull Request #24 · javascript-tutorial/zh-hant.javascript.info

Conversation

tom76kimo commented Aug 28, 2019

Copy link

Copy Markdown

Contributor

Target chapter

`1-js/01-getting-started/2-manuals-specifications`

Modified files

File name	Change（reason）
`article.md`	翻譯繁體中文

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

tom76kimo added review needed needs +1 ready to merge labels

Aug 28, 2019

javascript-translate-bot requested a review from a team

August 28, 2019 10:19

iliakan mentioned this pull request

Aug 28, 2019

Chinese Traditional Translation Progress #1

Open

CLAassistant commented Aug 28, 2019 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

All committers have signed the CLA.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

tom76kimo assigned ArvinH, kaddopur and lenchen1112

Aug 28, 2019

lenchen1112 requested changes

Aug 28, 2019

View reviewed changes

lenchen1112 left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some formatting and translate suggestions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/01-getting-started/2-manuals-specifications/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/01-getting-started/2-manuals-specifications/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/01-getting-started/2-manuals-specifications/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/01-getting-started/2-manuals-specifications/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/01-getting-started/2-manuals-specifications/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/01-getting-started/2-manuals-specifications/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot removed the review needed label

Aug 28, 2019

javascript-translate-bot commented Aug 28, 2019

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added the changes requested label

Aug 28, 2019

lenchen1112 removed the ready to merge label

Aug 28, 2019

lenchen1112 commented Aug 28, 2019

Copy link

Copy Markdown

Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

竟然有這東西 lol

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ArvinH reviewed

Aug 28, 2019

View reviewed changes

Comment thread

1-js/01-getting-started/2-manuals-specifications/article.md Outdated

		- MDN (Mozilla) JavaScript Reference 是一個包含了範例以及其他資訊的手冊，很適合拿來獲取個別函式或是方法的深入資訊。

		- MDN (Mozilla) JavaScript Reference is a manual with examples and other information. It's great to get in-depth information about individual language functions, methods etc.
		你可以在這裡找到 <https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference>.

ArvinH Aug 28, 2019

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

根據上下文，或許可以改成這樣？

Suggested change

	你可以在這裡找到 <https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference>.
	你可以從這裡尋找資訊 <https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference>.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

tom76kimo Aug 29, 2019

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/01-getting-started/2-manuals-specifications/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/01-getting-started/2-manuals-specifications/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

ArvinH commented Aug 28, 2019

Copy link

Copy Markdown

Contributor

@tom76kimo 你的 CLA 發生什麼事～

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

tom76kimo commented Aug 28, 2019

Copy link

Copy Markdown

Contributor Author

第一個 commit 用錯帳號的樣子~

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

lenchen1112 assigned tom76kimo

Sep 1, 2019

lenchen1112 commented Sep 2, 2019

Copy link

Copy Markdown

Contributor

@tom76kimo 是有沒要改～

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

lenchen1112 requested changes

Sep 3, 2019

View reviewed changes

Comment thread

1-js/01-getting-started/2-manuals-specifications/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot commented Sep 3, 2019

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

lenchen1112 requested changes

Sep 3, 2019

View reviewed changes

Comment thread

1-js/01-getting-started/2-manuals-specifications/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot commented Sep 3, 2019

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

lenchen1112 commented Sep 5, 2019

Copy link

Copy Markdown

Contributor

記得 rebase master，要先 sync origin 的 commit 喔，不然 suggestion 的會沒打上去

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

tom76kimo force-pushed the 1.1.2 branch from f05df90 to 6c905d6 Compare

September 5, 2019 10:06


          Add partial translation

68b7c45

Finish translation

Apply suggestions from code review

Co-Authored-By: Len Chen <[email protected]>
Co-Authored-By: ArvinH <[email protected]>

tom76kimo force-pushed the 1.1.2 branch from 6c905d6 to 68b7c45 Compare

September 5, 2019 10:11

tom76kimo commented Sep 5, 2019

Copy link

Copy Markdown

Contributor Author

Updated

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

lenchen1112 approved these changes

Sep 5, 2019

View reviewed changes

lenchen1112 left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work 🚀

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

javascript-translate-bot removed the changes requested label

Sep 5, 2019

ArvinH approved these changes

Sep 5, 2019

View reviewed changes

tom76kimo merged commit 6ded928 into javascript-tutorial:master

Sep 6, 2019

javascript-translate-bot commented Sep 6, 2019

Copy link

Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

tom76kimo deleted the 1.1.2 branch

September 6, 2019 02:35

Reviewers

ArvinH

ArvinH approved these changes

lenchen1112

lenchen1112 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

tom76kimo commented Aug 28, 2019

Target chapter

1-js/01-getting-started/2-manuals-specifications

Modified files

Uh oh!

CLAassistant commented Aug 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lenchen1112 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Aug 28, 2019

Uh oh!

lenchen1112 commented Aug 28, 2019

Uh oh!

ArvinH Aug 28, 2019

Choose a reason for hiding this comment

Uh oh!

tom76kimo Aug 29, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ArvinH commented Aug 28, 2019

Uh oh!

tom76kimo commented Aug 28, 2019

Uh oh!

lenchen1112 commented Sep 2, 2019

Uh oh!

Uh oh!

javascript-translate-bot commented Sep 3, 2019

Uh oh!

Uh oh!

javascript-translate-bot commented Sep 3, 2019

Uh oh!

lenchen1112 commented Sep 5, 2019

Uh oh!

tom76kimo commented Sep 5, 2019

Uh oh!

lenchen1112 left a comment

Choose a reason for hiding this comment

Uh oh!

javascript-translate-bot commented Sep 6, 2019

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

`1-js/01-getting-started/2-manuals-specifications`

CLAassistant commented Aug 28, 2019 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.