GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Hello, world! by kaddopur · Pull Request #28 · javascript-tutorial/zh-hant.javascript.info

Conversation

kaddopur commented Aug 31, 2019

Copy link

Copy Markdown

Contributor

Target chapter

`1-js/01-getting-started/1-intro`

Modified files

File name	Change（reason）
`article.md`	翻譯繁體中文
`1-task-folder/*`	翻譯繁體中文

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

kaddopur added 4 commits

August 31, 2019 10:03


          temp

d1e3c73


          finish artile

7cf990d


          translate tasks

ffcec29


          handle blank line

3734f33

kaddopur added the review needed label

Aug 31, 2019

javascript-translate-bot requested a review from a team

August 31, 2019 03:38

iliakan mentioned this pull request

Aug 31, 2019

Chinese Traditional Translation Progress #1

Open

CLAassistant commented Aug 31, 2019 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

All committers have signed the CLA.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          update colon

5b78d74

ArvinH previously approved these changes

Aug 31, 2019

View reviewed changes

javascript-translate-bot added needs +1 and removed review needed labels

Aug 31, 2019

lenchen1112 reviewed

Aug 31, 2019

View reviewed changes

Comment thread

1-js/02-first-steps/01-hello-world/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

lenchen1112 reviewed

Aug 31, 2019

View reviewed changes

Comment thread

1-js/02-first-steps/01-hello-world/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

lenchen1112 requested changes

Aug 31, 2019

View reviewed changes

lenchen1112 left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

生哥根本對岸來的吧，對岸用語超多

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/02-first-steps/01-hello-world/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/02-first-steps/01-hello-world/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/02-first-steps/01-hello-world/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/02-first-steps/01-hello-world/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/02-first-steps/01-hello-world/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/02-first-steps/01-hello-world/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/02-first-steps/01-hello-world/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/02-first-steps/01-hello-world/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/02-first-steps/01-hello-world/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/02-first-steps/01-hello-world/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added the changes requested label

Aug 31, 2019

javascript-translate-bot commented Aug 31, 2019

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Update 1-js/02-first-steps/01-hello-world/article.md

e1c4164

Co-Authored-By: Len Chen <[email protected]>

kaddopur dismissed ArvinH’s stale review via

e1c4164

August 31, 2019 08:03

kaddopur and others added 11 commits

August 31, 2019 16:04


          Update 1-js/02-first-steps/01-hello-world/article.md

88f4159

Co-Authored-By: Len Chen <[email protected]>


          Update 1-js/02-first-steps/01-hello-world/article.md

50ec945

Co-Authored-By: Len Chen <[email protected]>


          Update 1-js/02-first-steps/01-hello-world/article.md

cb31764

Co-Authored-By: Len Chen <[email protected]>


          Update 1-js/02-first-steps/01-hello-world/article.md

0a10a71

Co-Authored-By: Len Chen <[email protected]>


          Update 1-js/02-first-steps/01-hello-world/article.md

ac0ad11

Co-Authored-By: Len Chen <[email protected]>


          Update 1-js/02-first-steps/01-hello-world/article.md

31abce2

Co-Authored-By: Len Chen <[email protected]>


          Update 1-js/02-first-steps/01-hello-world/article.md

06e8c6f

Co-Authored-By: Len Chen <[email protected]>


          Update 1-js/02-first-steps/01-hello-world/article.md

ae3c3c7

Co-Authored-By: Len Chen <[email protected]>


          Update 1-js/02-first-steps/01-hello-world/article.md

6582a9d

Co-Authored-By: Len Chen <[email protected]>


          Update 1-js/02-first-steps/01-hello-world/article.md

34d7406

Co-Authored-By: Len Chen <[email protected]>


          Update 1-js/02-first-steps/01-hello-world/article.md

f938e84

Co-Authored-By: Len Chen <[email protected]>

kaddopur and others added 3 commits

August 31, 2019 16:09


          Update 1-js/02-first-steps/01-hello-world/article.md

d7154f8

Co-Authored-By: Len Chen <[email protected]>


          Update 1-js/02-first-steps/01-hello-world/article.md

3cb9ba4

Co-Authored-By: Len Chen <[email protected]>


          Update 1-js/02-first-steps/01-hello-world/article.md

8c6056d

Co-Authored-By: Len Chen <[email protected]>

kaddopur requested a review from lenchen1112

August 31, 2019 08:12

javascript-translate-bot removed the changes requested label

Aug 31, 2019

lenchen1112 approved these changes

Aug 31, 2019

View reviewed changes

lenchen1112 assigned kaddopur

Sep 1, 2019

ArvinH approved these changes

Sep 1, 2019

View reviewed changes

Comment thread

1-js/02-first-steps/01-hello-world/article.md

		使用獨立的檔案的好處是，瀏覽器會下載它且將之存入 [快取（cache）](https://en.wikipedia.org/wiki/Web_cache)。

		Other pages that reference the same script will take it from the cache instead of downloading it, so the file is actually downloaded only once.
		而當其他頁面需要使用同一份腳本時，就會省略下載而從快取中拿取，這個腳本實際上只被下載了一次。

ArvinH Sep 1, 2019

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

	而當其他頁面需要使用同一份腳本時，就會省略下載而從快取中拿取，這個腳本實際上只被下載了一次。
	而當其他頁面需要使用同一份腳本時，就會省略下載而從快取中拿取，因此這個腳本實際上只被下載了一次。

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

kaddopur merged commit 9657d50 into javascript-tutorial:master

Sep 1, 2019

javascript-translate-bot commented Sep 1, 2019

Copy link

Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

kaddopur deleted the hello_world branch

September 1, 2019 08:07

Reviewers

ArvinH

ArvinH approved these changes

lenchen1112

lenchen1112 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

kaddopur

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

kaddopur commented Aug 31, 2019

Target chapter

1-js/01-getting-started/1-intro

Modified files

Uh oh!

CLAassistant commented Aug 31, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lenchen1112 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Aug 31, 2019

Uh oh!

ArvinH Sep 1, 2019

Choose a reason for hiding this comment

Uh oh!

javascript-translate-bot commented Sep 1, 2019

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

`1-js/01-getting-started/1-intro`

CLAassistant commented Aug 31, 2019 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.