GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Coding Style by lenchen1112 · Pull Request #43 · javascript-tutorial/zh-hant.javascript.info

Conversation

@lenchen1112

@lenchen1112 lenchen1112 commented Sep 11, 2019

Copy link
Copy Markdown
Contributor

Target chapter

1-js/03-code-quality/02-coding-style

Modified files

File name Change（reason）
article.md 翻譯繁體中文
1-style-errors/* 翻譯繁體中文

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@lenchen1112
feat: translation of Coding Style
ba58b90
@lenchen1112
lenchen1112 requested a review from a team September 11, 2019 07:31
@lenchen1112 lenchen1112 self-assigned this Sep 11, 2019
@javascript-translate-bot javascript-translate-bot added the review needed label Sep 11, 2019
@iliakan iliakan mentioned this pull request Sep 11, 2019
Chinese Traditional Translation Progress #1
Open
kaddopur
kaddopur reviewed Sep 17, 2019
View reviewed changes
Comment thread 1-js/03-code-quality/02-coding-style/1-style-errors/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
ArvinH
ArvinH approved these changes Sep 17, 2019
View reviewed changes
Comment thread 1-js/03-code-quality/02-coding-style/article.md
```warn header="There are no \"you must\" rules"
Nothing is set in stone here. These are style preferences, not religious dogmas.
```warn header="沒有任何規則是 \"你一定得\" 採用的"
沒有什麼規則是被刻在石頭上的，這只是風格喜好，不是宗教信條。

@ArvinH ArvinH Sep 17, 2019

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] 我是覺得直翻也不錯啦

Suggested change
沒有什麼規則是被刻在石頭上的，這只是風格喜好，不是宗教信條。
沒有什麼規則是不可改變的，這只是風格喜好，不是宗教信條。

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@lenchen1112 lenchen1112 Sep 19, 2019

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

這邊我猜是有摩西把天啓刻到石板的隱喻啦，所以直翻可能比較能保留這層意思

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ArvinH reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@javascript-translate-bot javascript-translate-bot added needs +1 and removed review needed labels Sep 17, 2019
@lenchen1112 @kaddopur
Update 1-js/03-code-quality/02-coding-style/1-style-errors/solution.md
f8f98ea 
Co-Authored-By: Jason Huang <[email protected]>
@lenchen1112

lenchen1112 commented Sep 26, 2019

Copy link
Copy Markdown
Contributor Author

@kaddopur
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kaddopur
kaddopur approved these changes Sep 29, 2019
View reviewed changes
@lenchen1112
lenchen1112 merged commit 9042cb4 into javascript-tutorial:master Sep 29, 2019
@javascript-translate-bot

javascript-translate-bot commented Sep 29, 2019

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArvinH ArvinH ArvinH approved these changes
@kaddopur kaddopur kaddopur approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@lenchen1112 lenchen1112

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@lenchen1112 @javascript-translate-bot @ArvinH @kaddopur
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.