GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Ninja code by lenchen1112 · Pull Request #49 · javascript-tutorial/zh-hant.javascript.info

Conversation

@lenchen1112

@lenchen1112 lenchen1112 commented Sep 24, 2019

Copy link
Copy Markdown
Contributor

Target chapter

1-js/03-code-quality/04-ninja-code

Modified files

File name Change(reason)
article.md 翻譯繁體中文

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
lenchen1112 and others added 3 commits September 13, 2019 17:53
@lenchen1112
feat: translate 50% of Ninja Code
17f0c14
@lenchen1112
feat: translation of Ninja Code
52bdbc9
@lenchen1112 @kaddopur
Apply suggestions from code review
8678dde
Co-Authored-By: Jason Huang <[email protected]>
@lenchen1112
lenchen1112 requested a review from a team September 24, 2019 08:24
@lenchen1112 lenchen1112 self-assigned this Sep 24, 2019
@javascript-translate-bot javascript-translate-bot added the review needed label Sep 24, 2019
@iliakan iliakan mentioned this pull request Sep 24, 2019
Chinese Traditional Translation Progress #1
Open
ArvinH
ArvinH approved these changes Sep 24, 2019
View reviewed changes
@javascript-translate-bot javascript-translate-bot added needs +1 and removed review needed labels Sep 24, 2019
kaddopur
kaddopur approved these changes Sep 29, 2019
View reviewed changes
@lenchen1112
lenchen1112 merged commit 8d9c669 into javascript-tutorial:master Sep 29, 2019
@javascript-translate-bot

javascript-translate-bot commented Sep 29, 2019

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArvinH ArvinH ArvinH approved these changes
@kaddopur kaddopur kaddopur approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@lenchen1112 lenchen1112

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@lenchen1112 @javascript-translate-bot @ArvinH @kaddopur
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.