GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Objects by lenchen1112 · Pull Request #52 · javascript-tutorial/zh-hant.javascript.info

Conversation

@lenchen1112

@lenchen1112 lenchen1112 commented Sep 29, 2019

Copy link
Copy Markdown
Contributor

Target chapter

1-js/04-object-basics/01-object

Modified files

File name Change（reason）
article.md 翻譯繁體中文
2-hello-object/* 翻譯繁體中文
3-is-empty/* 翻譯繁體中文
5-sum-object/* 翻譯繁體中文
8-multiply-numeric/* 翻譯繁體中文

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
lenchen1112 added 2 commits September 28, 2019 13:29
@lenchen1112
feat: translate 50% of 1-04-01-object
05cb696
@lenchen1112
feat: translate 100% of 1-04-01-object
c163928
@lenchen1112
lenchen1112 requested a review from a team September 29, 2019 09:31
@lenchen1112 lenchen1112 self-assigned this Sep 29, 2019
@javascript-translate-bot javascript-translate-bot added the review needed label Sep 29, 2019
@iliakan iliakan mentioned this pull request Sep 29, 2019
Chinese Traditional Translation Progress #1
Open
ArvinH
ArvinH reviewed Oct 1, 2019
View reviewed changes
Comment thread 1-js/04-object-basics/01-object/2-hello-object/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/04-object-basics/01-object/3-is-empty/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/04-object-basics/01-object/8-multiply-numeric/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
ArvinH
ArvinH reviewed Oct 2, 2019
View reviewed changes
Comment thread 1-js/04-object-basics/01-object/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@lenchen1112 @ArvinH
Apply suggestions from code review
519d954 
Co-Authored-By: ArvinH <[email protected]>
ArvinH
ArvinH reviewed Oct 2, 2019
View reviewed changes
Comment thread 1-js/04-object-basics/01-object/article.md
In the code above, the property `obj.test` technically exists. So the `in` operator works right.

Situations like this happen very rarely, because `undefined` is usually not assigned. We mostly use `null` for "unknown" or "empty" values. So the `in` operator is an exotic guest in the code.
類似的情況非常少發生，因為 `undefined` 通常不會被指定，我們對於 "未知" 或 "空白" 的值大多會使用 `null`，所以 `in` 運算子可以算是程式碼的過客。

@ArvinH ArvinH Oct 2, 2019

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exotic guest 也太難翻...過客感覺有點怪，但也想不到更好的 lol

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@lenchen1112 lenchen1112 Oct 2, 2019

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaddopur @tom76kimo 來來來一起想想要怎麼翻比較好

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@tom76kimo tom76kimo Oct 12, 2019

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我覺得可以

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lenchen1112 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
ArvinH
ArvinH approved these changes Oct 2, 2019
View reviewed changes
@javascript-translate-bot javascript-translate-bot added needs +1 and removed review needed labels Oct 2, 2019
@lenchen1112
Merge branch 'master' into 1-04-01
048cf7f
tom76kimo
tom76kimo approved these changes Oct 12, 2019
View reviewed changes
@lenchen1112
Merge branch 'master' into 1-04-01
f21394f
@lenchen1112
lenchen1112 merged commit e5e4edb into javascript-tutorial:master Oct 12, 2019
@javascript-translate-bot

javascript-translate-bot commented Oct 12, 2019

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArvinH ArvinH ArvinH approved these changes
+1 more reviewer
@tom76kimo tom76kimo tom76kimo approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@lenchen1112 lenchen1112

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@lenchen1112 @javascript-translate-bot @ArvinH @tom76kimo
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.