GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Symbol type by ArvinH · Pull Request #66 · javascript-tutorial/zh-hant.javascript.info

Conversation

Target chapter

`1-js/04-object-basics/03-symbol`

Modified files

File name	Change（reason）
`article.md`	翻譯繁體中文

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

ArvinH added 2 commits

October 19, 2019 16:21


          feat: draft, symbol translated version

883dcf2


          feat: translate Symbol

3f02c8a

javascript-translate-bot added the review needed label

Oct 19, 2019

javascript-translate-bot requested a review from a team

October 19, 2019 08:11

iliakan mentioned this pull request

Oct 19, 2019

Chinese Traditional Translation Progress #1

Open

lenchen1112 commented Oct 19, 2019

Copy link

Copy Markdown

Contributor

我之前 Symbol 都有翻 符號，資料的 type 都是翻 類型，看要不要統一一下

ArvinH reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          fix: comments

5606b9c

lenchen1112 requested changes

Oct 20, 2019

View reviewed changes

lenchen1112 left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

裡面有些 他 跟 它 混用的情況看要不要也統一一下～

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/04-object-basics/03-symbol/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/04-object-basics/03-symbol/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/04-object-basics/03-symbol/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/04-object-basics/03-symbol/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/04-object-basics/03-symbol/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/04-object-basics/03-symbol/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/04-object-basics/03-symbol/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/04-object-basics/03-symbol/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/04-object-basics/03-symbol/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/04-object-basics/03-symbol/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot removed the review needed label

Oct 20, 2019

javascript-translate-bot commented Oct 20, 2019

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added the changes requested label

Oct 20, 2019

ArvinH commented Oct 20, 2019

Copy link

Copy Markdown

Contributor Author

裡面有些他跟它混用的情況看要不要也統一一下～

我再檢查看看，我是想都用 "它"，可能有漏掉

lenchen1112 reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ArvinH and others added 2 commits

October 21, 2019 12:18


          fix: 他 -> 它

453661a


          Apply suggestions from code review

3c5a42f

Co-Authored-By: Len Chen <[email protected]>

ArvinH commented

Oct 21, 2019

View reviewed changes

Comment thread

1-js/04-object-basics/03-symbol/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/04-object-basics/03-symbol/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/04-object-basics/03-symbol/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/04-object-basics/03-symbol/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/04-object-basics/03-symbol/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/04-object-basics/03-symbol/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.


          fix: review

6acd7bd

ArvinH requested review from a team and lenchen1112

October 21, 2019 03:36


          fix: review

14a546f

lenchen1112 reviewed

Oct 21, 2019

View reviewed changes

Comment thread

1-js/04-object-basics/03-symbol/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

lenchen1112 approved these changes

Oct 21, 2019

View reviewed changes

lenchen1112 left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work 🚀

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

javascript-translate-bot added needs +1 and removed changes requested labels

Oct 21, 2019


          Merge branch 'master' into 1-04-03-v2

ba641e5

lenchen1112 requested changes

Oct 21, 2019

View reviewed changes

Comment thread

1-js/04-object-basics/03-symbol/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added the changes requested label

Oct 21, 2019

javascript-translate-bot commented Oct 21, 2019

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Update 1-js/04-object-basics/03-symbol/article.md

e7d7d7e

Co-Authored-By: Len Chen <[email protected]>

lenchen1112 approved these changes

Oct 21, 2019

View reviewed changes

javascript-translate-bot removed the changes requested label

Oct 21, 2019

lenchen1112 assigned ArvinH

Oct 23, 2019

tom76kimo approved these changes

Oct 30, 2019

View reviewed changes


          Merge branch 'master' into 1-04-03-v2

81bfaa4

ArvinH merged commit 76544a9 into javascript-tutorial:master

Nov 4, 2019

javascript-translate-bot commented Nov 4, 2019

Copy link

Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ArvinH deleted the 1-04-03-v2 branch

November 4, 2019 03:46

Reviewers

lenchen1112

lenchen1112 approved these changes

+1 more reviewer

tom76kimo

tom76kimo approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

ArvinH

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

ArvinH commented Oct 19, 2019

Target chapter

1-js/04-object-basics/03-symbol

Modified files

Uh oh!

lenchen1112 commented Oct 19, 2019

Uh oh!

lenchen1112 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Oct 20, 2019

Uh oh!

ArvinH commented Oct 20, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lenchen1112 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

javascript-translate-bot commented Oct 21, 2019

Uh oh!

javascript-translate-bot commented Nov 4, 2019

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

`1-js/04-object-basics/03-symbol`