GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — WeakMap and WeakSet by ArvinH · Pull Request #67 · javascript-tutorial/zh-hant.javascript.info

Conversation

@ArvinH

@ArvinH ArvinH commented Oct 20, 2019

Copy link
Copy Markdown
Contributor

Target chapter

1-js/05-data-types/08-weakmap-weakset

Modified files

File name Change（reason）
article.md 翻譯繁體中文
01-recipients-read/* 翻譯繁體中文
02-recipients-when-read/* 翻譯繁體中文

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ArvinH added 4 commits October 20, 2019 02:55
@ArvinH
feat: draft
041a867
@ArvinH
feat: article done
68c6e8c
@ArvinH
feat: weakmap-weakset done
ab8a64d
@ArvinH
chore: wording
eba686d
@javascript-translate-bot javascript-translate-bot added the review needed label Oct 20, 2019
@javascript-translate-bot
javascript-translate-bot requested a review from a team October 20, 2019 04:33
@iliakan iliakan mentioned this pull request Oct 20, 2019
Chinese Traditional Translation Progress #1
Open
lenchen1112
lenchen1112 requested changes Oct 21, 2019
View reviewed changes
Comment thread 1-js/05-data-types/08-weakmap-weakset/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/05-data-types/08-weakmap-weakset/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/05-data-types/08-weakmap-weakset/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/05-data-types/08-weakmap-weakset/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/05-data-types/08-weakmap-weakset/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/05-data-types/08-weakmap-weakset/01-recipients-read/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/05-data-types/08-weakmap-weakset/01-recipients-read/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/05-data-types/08-weakmap-weakset/02-recipients-when-read/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/05-data-types/08-weakmap-weakset/02-recipients-when-read/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/05-data-types/08-weakmap-weakset/02-recipients-when-read/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@javascript-translate-bot javascript-translate-bot removed the review needed label Oct 21, 2019
@javascript-translate-bot

javascript-translate-bot commented Oct 21, 2019

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@javascript-translate-bot javascript-translate-bot added the changes requested label Oct 21, 2019
ArvinH
ArvinH commented Oct 21, 2019
View reviewed changes
Comment thread 1-js/05-data-types/08-weakmap-weakset/article.md Outdated
```

Now we don't have to clean `visitsCountMap`. After `john` object becomes unreachable by all means except as a key of `WeakMap`, it gets removed from memory, along with the information by that key from `WeakMap`.
現在我們不用清理 `visitsCountMap`。當 `john` 物件變得不可存取，只剩下作為 `WeakMap` 的鍵後，它會從記憶體中被移除，連同那些從 `WeakMap` 的鍵得來的資訊。

@ArvinH ArvinH Oct 21, 2019

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

變得 改成 變成 感覺順一些？

Suggested change
現在我們不用清理 `visitsCountMap`。當 `john` 物件變得不可存取，只剩下作為 `WeakMap` 的鍵後，它會從記憶體中被移除，連同那些從 `WeakMap` 的鍵得來的資訊。
現在我們不用清理 `visitsCountMap` 了。當 `john` 物件變成除了作為 `WeakMap` 的鍵值以外，其餘皆不可達的情況時，它就會連同那些從 `WeakMap` 的鍵得來的資訊，一起從記憶體中被移除。

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lenchen1112 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
ArvinH and others added 2 commits October 21, 2019 18:15
@ArvinH @lenchen1112
Apply suggestions from code review
1977142 
Co-Authored-By: Len Chen <[email protected]>
@ArvinH @lenchen1112
Update 1-js/05-data-types/08-weakmap-weakset/article.md
0721aab 
Co-Authored-By: Len Chen <[email protected]>
lenchen1112
lenchen1112 approved these changes Oct 21, 2019
View reviewed changes
@javascript-translate-bot javascript-translate-bot added needs +1 and removed changes requested labels Oct 21, 2019
ArvinH
ArvinH commented Oct 21, 2019
View reviewed changes
Comment thread 1-js/05-data-types/08-weakmap-weakset/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
ArvinH added 2 commits October 21, 2019 19:15
@ArvinH
Update 1-js/05-data-types/08-weakmap-weakset/article.md
4ab3ffa
@ArvinH
Merge branch 'master' into 1-05-08
f3037b9
@lenchen1112 lenchen1112 assigned ArvinH Oct 23, 2019
tom76kimo
tom76kimo approved these changes Oct 28, 2019
View reviewed changes
@ArvinH
ArvinH merged commit 8404726 into javascript-tutorial:master Oct 29, 2019
@javascript-translate-bot

javascript-translate-bot commented Oct 29, 2019

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ArvinH
ArvinH deleted the 1-05-08 branch October 29, 2019 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lenchen1112 lenchen1112 lenchen1112 approved these changes
+1 more reviewer
@tom76kimo tom76kimo tom76kimo approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@ArvinH ArvinH

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@ArvinH @javascript-translate-bot @tom76kimo @lenchen1112
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.