GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Private and protected properties and methods by ish-kafel · Pull Request #451 · javascript-tutorial/zh.javascript.info

Conversation

@ish-kafel

@ish-kafel ish-kafel commented Aug 14, 2019 •
edited by lycheeEng
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

目标章节：1-js/09-classes/04-private-protected-properties-methods

当前上游最新 commit：7fd3eb1

所做更改如下：

文件名 参考上游 commit 更改（理由）
article.md 6d1fa5d 翻译为中文

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ish-kafel
Translate into Chinese
eb0e318 
Translate into Chinese
@javascript-translate-bot javascript-translate-bot added the review needed label Aug 14, 2019
@javascript-translate-bot
javascript-translate-bot requested a review from a team August 14, 2019 08:27
@CLAassistant

CLAassistant commented Aug 14, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iliakan iliakan mentioned this pull request Aug 14, 2019
Chinese Translation Progress #324
Closed
@lycheeEng

lycheeEng commented Aug 14, 2019

Copy link
Copy Markdown
Collaborator

校对认领
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lycheeEng lycheeEng added 正在校对 and removed review needed labels Aug 14, 2019
@lycheeEng

lycheeEng commented Aug 14, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

看了一下英文版，原作者对这部分内容有改动，要不你先与英文版同步修改一下？
英文版：https://github.com/javascript-tutorial/en.javascript.info/blob/master/1-js/09-classes/04-private-protected-properties-methods/article.md
ish-kafel reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ish-kafel
Update article.md
6353ee1 
同步英文版
@ish-kafel

ish-kafel commented Aug 15, 2019

Copy link
Copy Markdown
Contributor Author

已和英文版同步
lycheeEng reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lycheeEng
lycheeEng reviewed Aug 16, 2019
View reviewed changes

@lycheeEng lycheeEng left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

校对完成，感谢翻译

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 1-js/09-classes/04-private-protected-properties-methods/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/09-classes/04-private-protected-properties-methods/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/09-classes/04-private-protected-properties-methods/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/09-classes/04-private-protected-properties-methods/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/09-classes/04-private-protected-properties-methods/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/09-classes/04-private-protected-properties-methods/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/09-classes/04-private-protected-properties-methods/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/09-classes/04-private-protected-properties-methods/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/09-classes/04-private-protected-properties-methods/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/09-classes/04-private-protected-properties-methods/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@lycheeEng lycheeEng added changes requested and removed 正在校对 labels Aug 16, 2019
@ish-kafel
修正翻译
86eb69a
@ish-kafel

ish-kafel commented Aug 16, 2019

Copy link
Copy Markdown
Contributor Author

感谢校正，已修正翻译
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lycheeEng
lycheeEng approved these changes Aug 16, 2019
View reviewed changes
@javascript-translate-bot javascript-translate-bot added needs +1 and removed changes requested labels Aug 16, 2019
@lycheeEng

lycheeEng commented Aug 16, 2019

Copy link
Copy Markdown
Collaborator

再次感谢~
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lycheeEng
lycheeEng merged commit a19b51a into javascript-tutorial:master Aug 16, 2019
@javascript-translate-bot

javascript-translate-bot commented Aug 16, 2019

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #324 🎉 🎉 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lycheeEng lycheeEng added DONE and removed needs +1 labels Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@lycheeEng lycheeEng lycheeEng approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

DONE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@ish-kafel @CLAassistant @lycheeEng @javascript-translate-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.