GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Translate some chapters to [Jul 17, 2020] Part-6 (#795) by jtchen2k · Pull Request #804 · javascript-tutorial/zh.javascript.info

Conversation

@jtchen2k

@jtchen2k jtchen2k commented Jul 22, 2020

Copy link
Copy Markdown

目标章节: 2-ui

当前上游最新 commit:f38eb4e

本 PR 所做更改如下:

文件名 参考上游 commit 更改(理由)
1-js/05-data-types/02-number/article.md f38eb4e 修复 19 行中 73 亿和 7.2bn 不对应的问题
2-ui/3-event-details/6-pointer-events/article.md f38eb4e 翻译

此外还翻译了 some chapters to [Jul 17, 2020] Part-6 (#795) 中的其他内容。

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
jtchen2k added 7 commits July 22, 2020 23:16
@jtchen2k
Minor error fix in 1-js/05-data-types/02-number/article.md
2ffbff0
@jtchen2k
Translated 2-ui/3-event-details/6-pointer-events
e712a12
@jtchen2k
Translated some chapters to [Jul 17, 2020] Part-6 javascript-tutorial…
2ed7362
…#795
@jtchen2k
Translation improvement
4d9c735
@jtchen2k
Minor error fix in 1-js/05-data-types/02-number/article.md
1751ef1
@jtchen2k
Minor fix in 2-ui/3-event-details/1-mouse-events-basics
35e41e3
@jtchen2k
Minor fix in 2-ui/3-event-details/1-mouse-events-basics
74e81b4
@javascript-translate-bot javascript-translate-bot added the review needed label Jul 22, 2020
@javascript-translate-bot
javascript-translate-bot requested a review from a team July 22, 2020 18:55
@CLAassistant

CLAassistant commented Jul 22, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@leviding leviding mentioned this pull request Jul 23, 2020
需要跟进更新的部分 #798
Closed
4 tasks done
@leviding

leviding commented Jul 23, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Thanks for your contribution, we will review it.

Related #798

jtchen2k reacted with rocket emoji
All reactions
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@MartinsYong MartinsYong self-assigned this Jul 27, 2020
@MartinsYong MartinsYong added 正在校对 and removed review needed labels Jul 27, 2020
MartinsYong
MartinsYong suggested changes Jul 27, 2020
View reviewed changes

@MartinsYong MartinsYong left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢翻译,先 review 一部分

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread 2-ui/1-document/01-browser-environment/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 2-ui/1-document/01-browser-environment/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 2-ui/1-document/07-modifying-document/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 2-ui/1-document/07-modifying-document/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 2-ui/1-document/07-modifying-document/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 2-ui/1-document/07-modifying-document/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 2-ui/1-document/07-modifying-document/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 2-ui/2-events/01-introduction-browser-events/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 2-ui/2-events/05-dispatch-events/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 2-ui/2-events/05-dispatch-events/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added the changes requested label Jul 27, 2020
@javascript-translate-bot

javascript-translate-bot commented Jul 27, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jtchen2k and others added 2 commits July 27, 2020 21:19
@jtchen2k @MartinsYong
Update 2-ui/1-document/01-browser-environment/article.md
4c25b4f
Co-authored-by: Martin <[email protected]>
@jtchen2k @MartinsYong
Apply suggestions from code review
2027382
Co-authored-by: Martin <[email protected]>
@jtchen2k

jtchen2k commented Jul 27, 2020

Copy link
Copy Markdown
Author

感谢 Review
/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added review needed and removed changes requested labels Jul 27, 2020
MartinsYong
MartinsYong suggested changes Jul 29, 2020
View reviewed changes

@MartinsYong MartinsYong left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review 其中一部分

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread 2-ui/1-document/07-modifying-document/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 2-ui/3-event-details/1-mouse-events-basics/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 2-ui/3-event-details/1-mouse-events-basics/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 2-ui/3-event-details/1-mouse-events-basics/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 2-ui/3-event-details/1-mouse-events-basics/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 2-ui/3-event-details/6-pointer-events/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 2-ui/3-event-details/6-pointer-events/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 2-ui/3-event-details/6-pointer-events/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 2-ui/3-event-details/6-pointer-events/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 2-ui/3-event-details/6-pointer-events/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added changes requested and removed review needed labels Jul 29, 2020
@javascript-translate-bot

javascript-translate-bot commented Jul 29, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jtchen2k
jtchen2k commented Jul 29, 2020
View reviewed changes
Comment thread 2-ui/3-event-details/6-pointer-events/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@jtchen2k @MartinsYong
Apply suggestions from code review
cae00b1
Took some suggestions

Co-authored-by: Martin <[email protected]>
@jtchen2k

jtchen2k commented Jul 29, 2020

Copy link
Copy Markdown
Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot

javascript-translate-bot commented Aug 8, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@leviding leviding self-assigned this Aug 8, 2020
@jtchen2k bemself
Apply suggestions from code review
2311f11
Commit from suggestion

Co-authored-by: bemself <[email protected]>
@MartinsYong MartinsYong added review needed and removed changes requested labels Aug 30, 2020
@MartinsYong

MartinsYong commented Aug 30, 2020

Copy link
Copy Markdown
Member

2-ui/3-event-details/6-pointer-events/article.md
第 45 行再看一下
@BillChen2K

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@jtchen2k bemself
Update 2-ui/3-event-details/6-pointer-events/article.md
e42208a
Co-authored-by: bemself <[email protected]>
@jtchen2k

jtchen2k commented Sep 2, 2020

Copy link
Copy Markdown
Author

恩恩,已 commit
/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@MartinsYong

MartinsYong commented Sep 5, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

不好意思,我这里还有一些可能被你 miss 了
2-ui/1-document/07-modifying-document/article.md 第182 行;
2-ui/3-event-details/1-mouse-events-basics/article.md 第 67 行;
@BillChen2K

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@jtchen2k @MartinsYong
Apply suggestions from code review
36ae959
已补充 commit。

Co-authored-by: Martin <[email protected]>
@jtchen2k

jtchen2k commented Sep 15, 2020

Copy link
Copy Markdown
Author

Sorry for the late reply /done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot
javascript-translate-bot requested a review from a team September 15, 2020 03:06
MartinsYong
MartinsYong approved these changes Sep 17, 2020
View reviewed changes
@MartinsYong MartinsYong removed review needed 正在校对 labels Sep 17, 2020
leviding added 10 commits September 19, 2020 17:12
@leviding
Update article.md
5c08135
@leviding
Update article.md
03af158
@leviding
Update article.md
688f128
@leviding
Update index.html
8555741
@leviding
Update article.md
1ccd2ff
@leviding
Update article.md
b56cd7a
@leviding
Update article.md
1fe8f24
@leviding
Update article.md
97a42ac
@leviding
Update article.md
93604d9
@leviding
Update article.md
f49aae5
leviding
leviding approved these changes Sep 21, 2020
View reviewed changes

@leviding leviding left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@leviding
leviding merged commit f9cb07b into javascript-tutorial:master Sep 21, 2020
@leviding leviding added DONE and removed needs +1 labels Sep 21, 2020
@leviding

leviding commented Sep 21, 2020

Copy link
Copy Markdown
Member

感谢译者,感谢校对,经过了这么长时间,终于合并了 🤣

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leviding leviding leviding approved these changes
+2 more reviewers
@MartinsYong MartinsYong MartinsYong approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@MartinsYong MartinsYong

@leviding leviding

Labels

DONE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@jtchen2k @CLAassistant @leviding @javascript-translate-bot @MartinsYong
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.