GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||
GeezerVison is showing github.com — Test the removal of the whole document by espadrine · Pull Request #29 · json-patch/json-patch-tests ConversationSee also json-patch/json-patch2#17
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
|
There was an error while loading. Please reload this page.
|
replacing the document with null is not removing the document I believe the behavior of removing In https://github.com/JSON8/patch I return undefined |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
While that is compliant with the spec, it is unfortunate, as it breaks the expectation that the result remains a valid JSON document. I would recommend you change it to return null. I believe the behavior we want should be explicit rather than implicit or unspecified. The spec defines the semantics of all that it defines. In the meantime, having divergence in implementations' behavior is unfortunate. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Anyway, this repo contains JSON Patch tests and since your proposed behavior is not specified I'd 👎 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I'm not fond of the idea that removing the object converts it to the 9-character string |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.