GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — rdfToJson edge case when object = subject and predicate = rdf:type by umbreak · Pull Request #306 · jsonld-java/jsonld-java

Conversation

@umbreak

@umbreak umbreak commented Feb 1, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fixes #301

It seems that when fixing a previous issue with rdfToJson (related to @type) I introduced this bug.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@umbreak
rdfToJson edge case when object = subject and predicate = rdf:type
95cbd49
@dr0i
dr0i self-requested a review February 1, 2021 10:53
@dr0i dr0i self-assigned this Feb 1, 2021
@coveralls

coveralls commented Feb 1, 2021

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.003%) to 89.575% when pulling 95cbd49 on umbreak:issue_301 into a88eacf on jsonld-java:master.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dr0i
dr0i merged commit 506d761 into jsonld-java:master Feb 10, 2021
@dr0i

dr0i commented Feb 10, 2021

Copy link
Copy Markdown
Member

Thx @umbreak for the fix!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dr0i dr0i mentioned this pull request Feb 10, 2021
Issue with @type when subject and object are the same #301
Closed
@umbreak
umbreak deleted the issue_301 branch February 10, 2021 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dr0i dr0i Awaiting requested review from dr0i

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@dr0i dr0i

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Issue with @type when subject and object are the same

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@umbreak @coveralls @dr0i
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.