GeezerVison is showing github.com — Added support for JSON-LD 1.1 @json @type by umbreak · Pull Request #307 · jsonld-java/jsonld-java
Conversation
umbreak
commented
Feb 28, 2021
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Added support for Json literal
I've added the tests from the current test suite related to JSON literal. The only test that doesn't pass (which I remove from the manifest) is toRdf-js12. An unicode code point \u00F is meant to be lowercased to \u00f.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
coveralls
commented
Feb 28, 2021
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|

Coverage increased (+0.5%) to 90.055% when pulling 330c158 on umbreak:jsonld-11-type-json into 506d761 on jsonld-java:master.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Hi @umbreak , I don't know if your are aware of #283, also #284 (comment). I think there are some redundancies to ypur PR.
I don't know how, or if, we proceed on this.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
umbreak
commented
Mar 1, 2021
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|
The branch you are referring me to is an attempt to fully support of 1.1. I was hoping for a more iterative approach here where only some features are introduced (in order to not be stuck).
But I understand if you don't see it the same way.
|
gkellogg reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
The branch you are referring me to is an attempt to fully support of 1.1. I was hoping for a more iterative approach here where only some features are introduced
This was exactly my intention with that setup, see #277 (comment):
I think that with this setup, we can keep releasing from master whenever the build passes, while making available the 1.1 support that we currently have.
Maybe we should follow up on the suggestion by @ansell in #283 (comment) and merge #283 into develop, and move on from there (e.g. rebasing this on develop).
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
I'm fine with that approach too. Once you merge #283 into develop branch I can put this functionality in that branch.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
I merged #283 into the develop branch.
@umbreak as you proposed, you may go on and put the functionality into a PR against that develop branch.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Done in the develop branch
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|