GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fixed issue where expanded type IRI would be used rather than @type by daltontc · Pull Request #330 · jsonld-java/jsonld-java

Conversation

@daltontc

@daltontc daltontc commented Feb 16, 2022

Copy link
Copy Markdown

#329

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
daltontc added 4 commits February 16, 2022 16:39
@daltontc
Fixed issue where expanded type IRI would be used rather than @type
9c0bb7b
@daltontc
Handled blank node as type
c065878
@daltontc
Removed unused import
96efdd2
@daltontc
Changed throw type
f67e981
@daltontc daltontc changed the title Fixed issue where expanded type IRI would be used rather than @type #329 Fixed issue where expanded type IRI would be used rather than @type Feb 17, 2022
dr0i
dr0i requested changes Mar 4, 2022
View reviewed changes

@dr0i dr0i left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is strongly related to #242.
I think we have to keep the behaviour in case of labeling an rdf:type, i.e. don't use the @type keyword, while we should indeed use @type otherwise.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread core/src/test/resources/custom/frame-0010-out.jsonld
"rdf:type" : {
"@id" : "http://example.com/rdf/id",
"rdf:label" : "someLabel"
}

@dr0i dr0i Mar 4, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we loose the label which is not good.
Look at the playground.
I think it's not possible to have a label for @type keyword in this way.
See also #242.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread core/src/test/resources/json-ld.org/fromRdf-0020-out.jsonld
"@id": "http://example.com/Type"
}],
"@type" : ["http://example.com/Type"],
"http://example.com/prop1": [{"@id": "http://example.com/Obj1"}],

@dr0i dr0i Mar 4, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... while your code seems to be good in this case - compare
without @type and with @type , there is no difference in the nquads.
See also #242 (comment) where this is reported to be the expected outcome.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@dr0i dr0i assigned daltontc Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dr0i dr0i dr0i requested changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@daltontc daltontc

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@daltontc @dr0i
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.