GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||||||||||||||||
GeezerVison is showing github.com — feat: libkubara and controller-gen for automated CRD generation by tuunit · Pull Request #628 · kubara-io/kubara Conversation
| |||||||||||||||||||||||||||||||||
| Filter | Insertions | Deletions | Net change |
|---|---|---|---|
| Raw diff | +1030 | -1167 | -137 |
| Without generated CRD YAML | +776 | -1167 | -391 |
| Go files only | +690 | -1090 | -400 |
| Go code only, without comments or blank lines | +567 | -924 | -357 |
| Replaced engine files and tests: render, store, defaults | +201 | -976 | -775 |
Diff without the generated CRD manifest:
git diff HEAD~8 --shortstat -- ':(exclude)*kubara.io_platformsetups.yaml'Diff for Go files only:
git diff HEAD~8 --shortstat -- '*.go'Count added Go code lines, without comments or blank lines:
git diff HEAD~8 -U0 -- '*.go' | grep -E '^\+([^+]|$)' | grep -v -E '^\+[[:space:]]*(//|/\*|\*|$)' | wc -l
Count deleted Go code lines, without comments or blank lines:
git diff HEAD~8 -U0 -- '*.go' | grep -E '^-([^-]|$)' | grep -v -E '^-[[:space:]]*(//|/\*|\*|$)' | wc -l
Diff on the exact files replaced by libkubara and controller-gen:
git diff HEAD~8 --shortstat -- \ src/internal/render/render.go \ src/internal/config/store.go \ src/internal/config/store_test.go \ src/internal/config/defaults.go \ src/internal/config/defaults_test.go
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| @@ -0,0 +1,244 @@ | |||
| --- | |||
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
NOTE: this file is auto generated by make generate and the workflow tests that it is up-to-date
the actual source for this yaml definition is our config located in:
src/internal/config/types.go
Sorry, something went wrong.
There was an error while loading. Please reload this page.
e0efc91 to
74bcb86
Compare
|
@tuunit still reviewing this, could you please rebase/solve the merge conflicts in the meantime? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
with the new format all fields are sorted alphabetically instead of the custom fixed order we generated before. coming after the big |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
c51c3d4 to
50e20e9
Compare
50e20e9 to
8f77fb8
Compare
revert: unnecessary none pointer for the helm repository which would have caused empty field on file persistence feat: introduction of controller-gen for reduce maintaince effort and deduplication of validation feat(controller-gen): first autogenerated crd for the platform setup config chore: remove deadcode ci(libkubara): fix config patching for new CRD based syntax fix: ensure defaulting for helmRepo.url chore: upgrade libkubara for k8s compatability Signed-off-by: Jan Larwig <[email protected]>
Signed-off-by: Jan Larwig <[email protected]>
Signed-off-by: Jan Larwig <[email protected]>
Signed-off-by: Jan Larwig <[email protected]>
0a89be6 to
6232332
Compare
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.