GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Manual cherrypick master branch changes to release-9.0 by roycaihw · Pull Request #752 · kubernetes-client/python

Conversation

@roycaihw

@roycaihw roycaihw commented Feb 8, 2019

Copy link
Copy Markdown
Member

changes in master branch got dropped by git pull -s ours when we merge master branch into release-9.0: #751

basically the 14th commit ("Merge branch 'master' of github.com:kubernetes-client/python into re") in https://github.com/kubernetes-client/python/pull/751/commits is empty, which means the 1~13 commits didn't get into release-9.0

this PR manually cherrypicked the 1~13 commits from https://github.com/kubernetes-client/python/pull/751/commits into release-9.0 branch to make sure the changes will be included in 9.0.0b1

  • (ignored five merge commits from robot and squashed four of my commits into one "update base submodule", so there are only five commits in this PR)

double checked the version constants and ran the script to re-generate the client. confirmed that nothing changes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
k8s-ci-robot reacted with hooray emoji
All reactions
  • 🎉 1 reaction
ramnes and others added 5 commits February 7, 2019 17:44
@ramnes @roycaihw
Use yaml.safe_load
273e0b5 
See kubernetes-client#718 for rationale.
@xvello @roycaihw
Update python-base ref to include yaml security fix
bd5b6a2
@rlenferink @roycaihw
Updated OWNERS file to include link to docs
21775dc
@roycaihw
update base submodule
128e015
@iamneha @roycaihw
Make dependancy adal optional
ce0dd71
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 8, 2019
@k8s-ci-robot
k8s-ci-robot requested review from lavalamp and yliaog February 8, 2019 02:18
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 8, 2019
@roycaihw

roycaihw commented Feb 8, 2019

Copy link
Copy Markdown
Member Author

/assign @yliaog
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@k8s-ci-robot k8s-ci-robot assigned yliaog Feb 8, 2019
@yliaog

yliaog commented Feb 8, 2019

Copy link
Copy Markdown
Contributor

/lgtm
/approve
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 8, 2019
@k8s-ci-robot

k8s-ci-robot commented Feb 8, 2019

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roycaihw, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [roycaihw,yliaog]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@k8s-ci-robot
k8s-ci-robot merged commit 686d64c into kubernetes-client:release-9.0 Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lavalamp lavalamp Awaiting requested review from lavalamp
@yliaog yliaog Awaiting requested review from yliaog

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@yliaog yliaog

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@roycaihw @yliaog @k8s-ci-robot @ramnes @xvello @rlenferink @iamneha
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.