GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — fix(bind): treat an empty header value slice as an absent key by methakon · Pull Request #3175 · labstack/echo ConversationProblem
Note this is not reachable from a raw incoming HTTP request — ChangeGuard both reads. An empty value slice is treated like an absent key.
TestingFour tests in
With
Closes #3169
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsbindData indexed inputValue[0] on the scalar-map paths and on the
tagged-struct paths without checking the length, so a header whose value
slice was nil or empty panicked with "index out of range [0] with length 0"
instead of binding nothing. BindHeaders passes the request header map
straight to bindData, so BindHeaders inherited the panic.
Guard both reads. An empty slice now behaves like an absent key, while
[]string{""} - a present but empty value - still binds, so the check keys
on length rather than on the value being empty.
Closes labstack#3169
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersNo reviewsUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. BindHeaders panics on nil or empty header value slicesUh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |