GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — docs(middleware): correct CORS AllowMethods and AllowHeaders defaults by ZainnQureshii · Pull Request #3181 · labstack/echo

Conversation

@ZainnQureshii

@ZainnQureshii ZainnQureshii commented Oct 18, 2026

Copy link
Copy Markdown

Corrects two CORSConfig field comments in middleware/cors.go that no longer match what the middleware does in v5.

AllowHeaders. The comment said Defaults to empty list. No domains allowed for CORS. With an empty list, ToMiddleware actually copies the request's Access-Control-Request-Headers value into Access-Control-Allow-Headers on the preflight response (the allowHeaders != "" else branch in the preflight handler). That allows every requested header, the opposite of what the comment says. The comment now says so.

AllowMethods. The comment said Default value DefaultCORSConfig.AllowMethods, but DefaultCORSConfig was removed in v5 (listed under "Also removed defaults" in API_CHANGES_V5.md). The fallback is now named directly: the router's Allow value, or GET, HEAD, PUT, PATCH, POST, DELETE (the list ToMiddleware sets when AllowMethods is empty) when the router sets none.

Comment-only change. Ran go vet ./middleware/ and go test ./middleware/ -run CORS (pass).

Prepared with AI assistance (Claude Code) and reviewed with GitHub Copilot.

🤖 Generated with Claude Code

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ZainnQureshii @claude
docs(middleware): correct CORS AllowMethods and AllowHeaders defaults
e96b5a8
AllowHeaders said an empty list allows no domains; an empty list makes
the preflight response reflect Access-Control-Request-Headers.
AllowMethods pointed at DefaultCORSConfig, which v5 removed; it now
names the fallback methods used when the router sets no Allow header.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@ZainnQureshii

ZainnQureshii commented Nov 6, 2026

Copy link
Copy Markdown
Author

Hi, following up on this one. It only changes the AllowMethods and AllowHeaders comments in middleware/cors.go so they match what v5 does, would someone have a few minutes to look at it?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ZainnQureshii

ZainnQureshii commented Nov 11, 2026

Copy link
Copy Markdown
Author

@vishr could you take a look at the CORS comments, they now explain the AllowMethods fallback and how empty AllowHeaders reflects request headers?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@ZainnQureshii
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.