GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(middleware): escape static directory listing links by yuefdev · Pull Request #3182 · labstack/echo

Conversation

@yuefdev

@yuefdev yuefdev commented Oct 18, 2026

Copy link
Copy Markdown

Directory browsing puts the display name directly in href. Names such as hash#file.txt and query?.txt become fragments or queries, while colon:name.txt is blocked by html/template as a URL scheme.

Build a relative URL from the filename and use it in the default template, keeping the display name unchanged. Custom templates can use the new URL field; the existing fields remain available.

The regression follows the rendered link through Echo, dropping fragments as a browser does. Four cases fail before the fix; plain names, spaces, percent signs and ampersands remain covered.

Validation: all static middleware tests, go vet ./..., golint, staticcheck and gofmt pass. The full go test -race ./... passes on Ubuntu with Go 1.27.0; the Windows race run could not start because cgo is disabled there.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@yuefdev
fix(middleware): escape static directory listing links
218e445
Signed-off-by: Yusuf Efe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@yuefdev
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.