GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — WASM_X64: Support logical/bitwise opts by ubaidsk · Pull Request #1481 · lcompilers/lpython

Conversation

@ubaidsk

@ubaidsk ubaidsk commented Jan 31, 2023

Copy link
Copy Markdown
Collaborator

This PR adds support of logical/bitwise operations and, or and xor in the wasm_x64 backend.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ubaidsk added 5 commits January 31, 2023 21:21
@ubaidsk
X86Assembler: Implement and, or, xor logical/bitwise insts
6343ad1
@ubaidsk
Refactor: Move asm_xor_r32_r32() near other similar insts
d40523b
@ubaidsk
WASM_X64: Implement And, Or, Xor logical/bitwise insts
ef24e83
@ubaidsk
TEST: Enable suporting tests
9a0918f
@ubaidsk
Refactor: WASM_X64: Minor comment improvement
6dc77b9
@ubaidsk ubaidsk added the wasm_x64 label Jan 31, 2023
@ubaidsk
ubaidsk requested a review from certik January 31, 2023 15:59
@ubaidsk

ubaidsk commented Jan 31, 2023

Copy link
Copy Markdown
Collaborator Author

This is ready. Please possibly review and share feedback.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
certik
certik approved these changes Jan 31, 2023
View reviewed changes

@certik certik left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ubaidsk ubaidsk mentioned this pull request Jan 31, 2023
WASM, WASM_X64: Support shift operations #1482
Merged
@ubaidsk
ubaidsk merged commit 0331203 into lcompilers:main Jan 31, 2023
@ubaidsk
ubaidsk deleted the wasm_x64_logical_bitwise_opts branch January 31, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@certik certik certik approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

wasm_x64

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ubaidsk @certik
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.