GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Added set creation from list by swamishiju · Pull Request #2822 · lcompilers/lpython

Conversation

@swamishiju

@swamishiju swamishiju commented Feb 7, 2025

Copy link
Copy Markdown
Collaborator

Added functionality for set() to accept list argument

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Swaminath Shiju Swaminath Shiju
Added set creation from list
24a03ad
@swamishiju
swamishiju marked this pull request as draft February 7, 2025 08:17
@swamishiju
Fixed type mismatch
41f03e9
@swamishiju
swamishiju marked this pull request as ready for review February 10, 2025 08:10
@certik

certik commented Feb 17, 2025

Copy link
Copy Markdown
Contributor

You have to get the CI to pass, currently it is failing at:

{'returncode': 134} != {'returncode': 1}
{'stderr_hash': '32b0a24f111e577fe4fc5b3f4a5994b951e34dde7986b3fb750c5f5e'} != {'stderr_hash': '4811af471c73572b285e9ea01c8689abdd3cb32c717b3cd4876d2669'}
Diff against: tests/reference/run_dbg-test_assert_01-2f34744.stderr
1,7c1,2
<   File "tests/runtime_errors/test_assert_01.py", line 1
<     def test():
<   File "tests/runtime_errors/test_assert_01.py", line 4
<     test()
<   File "tests/runtime_errors/test_assert_01.py", line 2
<     assert False
< AssertionError
---
> *** buffer overflow detected ***: terminated
> Aborted (core dumped)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@swamishiju

swamishiju commented Feb 17, 2025

Copy link
Copy Markdown
Collaborator Author

Its weird im on a Mac and python run_tests.py gives all tests passed so im not entirely sure why it isnt working
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ubaidsk

ubaidsk commented Feb 17, 2025

Copy link
Copy Markdown
Collaborator

I am observing the same issue here. Probably the CI seems to be flaky.

compiler_tester.tester.RunException: Testing with reference output failed.
runtime_errors/test_assert_01.py * run_dbg
The JSON metadata differs against reference results
Reference JSON: tests/reference/run_dbg-test_assert_01-2f34744.json
Output JSON:    tests/output/run_dbg-test_assert_01-2f34744.json
Omitting 9 identical items
Differing items:
{'returncode': 134} != {'returncode': 1}
{'stderr_hash': '32b0a24f111e577fe4fc5b3f4a5994b951e34dde7986b3fb750c5f5e'} != {'stderr_hash': '4811af471c73572b285e9ea01c8689abdd3cb32c717b3cd4876d2669'}
Diff against: tests/reference/run_dbg-test_assert_01-2f34744.stderr
1,7c1,2
<   File "tests/runtime_errors/test_assert_01.py", line 1
<     def test():
<   File "tests/runtime_errors/test_assert_01.py", line 4
<     test()
<   File "tests/runtime_errors/test_assert_01.py", line 2
<     assert False
< AssertionError
---
> *** buffer overflow detected ***: terminated
> Aborted (core dumped)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@swamishiju swamishiju mentioned this pull request Feb 24, 2025
Inplace class definitions causes infinite looping #2826
Open
@swamishiju
Merge branch 'lcompilers:main' into main
82f4780
ubaidsk
ubaidsk approved these changes Mar 12, 2025
View reviewed changes

@ubaidsk ubaidsk left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ubaidsk
ubaidsk reviewed Mar 12, 2025
View reviewed changes
Comment thread src/lpython/semantics/python_ast_to_asr.cpp Resolved

Uh oh!

There was an error while loading. Please reload this page.
ubaidsk
ubaidsk requested changes Mar 12, 2025
View reviewed changes

@ubaidsk ubaidsk left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Posted a comment above. Let's fix the message.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@swamishiju @ubaidsk
Update src/lpython/semantics/python_ast_to_asr.cpp
9f3c21e 
Fixed error message

Co-authored-by: Mohammed Ubaid Shaikh <[email protected]>
@swamishiju

swamishiju commented Mar 12, 2025

Copy link
Copy Markdown
Collaborator Author

Thank you for pointing it out, I've committed it
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ubaidsk
ubaidsk approved these changes Mar 12, 2025
View reviewed changes
@ubaidsk
ubaidsk merged commit 22ea159 into lcompilers:main Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ubaidsk ubaidsk ubaidsk approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@swamishiju @certik @ubaidsk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.