GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — repo: allow init with a workdir that is the repository path by ck0i · Pull Request #7454 · libgit2/libgit2

Conversation

@ck0i

@ck0i ck0i commented Oct 31, 2026

Copy link
Copy Markdown

On Windows, git_repository_init_ext fails when workdir_path names the same directory as the repository path, while the same call without workdir_path succeeds. Treat a workdir that resolves to the repository path as if none was given, so the repo lands in a ".git" directory and no core.worktree entry is written. The natural-workdir check now normalizes separators and resolves "." and ".." so forms like backslashes or "repo/." still match.

Adds coverage for those cases. repo::init and the offline suite pass on Windows (MSVC).

Fixes #6823

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ck0i
repo: allow init with a workdir that is the repository path
580c4ec
When git_repository_init_ext is given a workdir_path that names the
repository path itself, treat it as if no working directory was given,
so that the repository goes in a ".git" directory inside it.

Also compare the working directory and the repository parent after
normalizing separators and "." and ".." components when deciding
whether the working directory is the natural one. Previously a path
with backslashes on Windows, or one spelled with a trailing ".", was
treated as a separate working directory and init failed or wrote an
unneeded core.worktree.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

git_repository_init_ext fails on Windows if you supply a working directory which is the same as the repo folder. Worked on earlier version

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@ck0i
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.