GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — odb: reject object and delta sizes that overflow by b84330808 · Pull Request #7457 · libgit2/libgit2 ConversationThe 7-bit size groups in pack object headers, pack-like loose object headers and delta headers are shifted into place without checking whether bits fall off the top. The existing checks (including the one from #7172) only stop once the shift reaches the width of the type, so the last group can still lose its high bits and a size that doesn't fit is accepted as a smaller one. For example, the delta header This checks that each group survives the shift and fails otherwise, like git's Tests cover the delta base and result sizes, a pack-like loose object read through
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsThe variable-length sizes in pack object headers, pack-like loose object headers and delta headers are decoded by shifting each 7-bit group into place. The existing checks only stop the shift once it reaches the width of the type, so the group that straddles the top of the type still has its high bits silently shifted out: a header whose size does not fit is accepted with a truncated size instead of being rejected. Check that each group survives the shift and fail otherwise, the same way git does with st_left_shift(). In the loose object parser, also shift in size_t: the group is held in an unsigned long, which is only 32 bits wide on Windows, and was shifted by up to 60 bits there. This branch has not been deployedNo deployments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersNo reviewsUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |