GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — odb: reject object and delta sizes that overflow by b84330808 · Pull Request #7457 · libgit2/libgit2

Conversation

@b84330808

@b84330808 b84330808 commented Nov 4, 2026

Copy link
Copy Markdown

The 7-bit size groups in pack object headers, pack-like loose object headers and delta headers are shifted into place without checking whether bits fall off the top. The existing checks (including the one from #7172) only stop once the shift reaches the width of the type, so the last group can still lose its high bits and a size that doesn't fit is accepted as a smaller one. For example, the delta header 90 80 80 80 80 80 80 80 80 02 decodes to 16 on 64-bit platforms, because the 0x02 at shift 63 is dropped.

This checks that each group survives the shift and fails otherwise, like git's st_left_shift(). In parse_header_packlike() the group is an unsigned long, so on Windows it was also shifted by up to 60 bits on a 32-bit type; it is now shifted as a size_t.

Tests cover the delta base and result sizes, a pack-like loose object read through git_odb_read(), git_odb_read_header() and git_odb_open_rstream(), and a pack header through the indexer. The pack test only fails without the fix where long is 64 bits; on Windows the existing bitsizeof(long) check already rejects that header.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@b84330808
odb: reject object and delta sizes that overflow
9ead2b4
The variable-length sizes in pack object headers, pack-like loose
object headers and delta headers are decoded by shifting each 7-bit
group into place. The existing checks only stop the shift once it
reaches the width of the type, so the group that straddles the top of
the type still has its high bits silently shifted out: a header whose
size does not fit is accepted with a truncated size instead of being
rejected.

Check that each group survives the shift and fail otherwise, the same
way git does with st_left_shift(). In the loose object parser, also
shift in size_t: the group is held in an unsigned long, which is only
32 bits wide on Windows, and was shifted by up to 60 bits there.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@b84330808
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.