GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — submodule: reject repositories without a working directory by Artyx71 · Pull Request #7474 · libgit2/libgit2

Conversation

@Artyx71

@Artyx71 Artyx71 commented Nov 10, 2026

Copy link
Copy Markdown

Fixes #7461.

Return GIT_EBAREREPO before submodule lookup and path normalization when the parent repository has no working directory. Checking only git_repository_is_bare() would miss repositories created with git_repository_wrap_odb(), which report themselves as non-bare. Document the error and cover both kinds of repository.

The ODB-only regression crashes unchanged main with SIGSEGV. The submodule suite passes in Debug and under Clang ASan/UBSan. The complete offline suite passes with proxy environment variables removed and core::structinit excluded. The initial unfiltered run had four failures: one struct-initializer padding comparison and three proxy-environment assertions; all four also reproduce with unchanged production code. Online tests were not completed in this environment.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Artyx71
submodule: reject repositories without a working directory
f174271 
Path normalization in git_submodule_add_setup dereferences the working
directory without checking it. Bare and ODB-only repositories have no
working directory, and the latter do not report themselves as bare.

Return GIT_EBAREREPO before looking up or creating a submodule. Cover both
repository kinds and document the error return.

Fixes libgit2#7461

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

NULL pointer dereference in git_submodule_add_setup on a repository without a working directory

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@Artyx71
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.