GeezerVison is showing github.com — Fix warnings: -Wsubobject-linkage & -Wreturn-type by ctrlcctrlv · Pull Request #232 · linuxdeploy/linuxdeploy
Conversation
ctrlcctrlv
commented
Nov 12, 2022
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Silences these two warnings:
- In file included from ./linuxdeploy/src/appdir_test_main.cpp:10:
./linuxdeploy/src/core/appdir.cpp:100:27: warning: ‘linuxdeploy::core::appdir::AppDir::PrivateData’ has a field ‘linuxdeploy::core::appdir::AppDir::PrivateData::copyOperationsStorage’ whose type uses the anonymous namespace [-Wsubobject-linkage]
- In member function ‘pipe_reader::result pipe_reader::read(std::vector&, std::chrono::milliseconds)’:
./linuxdeploy/src/subprocess/pipe_reader.cpp:59:1: warning: control reaches end of non-void function [-Wreturn-type]
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
./linuxdeploy/src/core/appdir.cpp:100:27: warning:
‘linuxdeploy::core::appdir::AppDir::PrivateData’ has a field
‘linuxdeploy::core::appdir::AppDir::PrivateData::copyOperationsStorage’
whose type uses the anonymous namespace [-Wsubobject-linkage]
./linuxdeploy/src/subprocess/pipe_reader.cpp: In member function
‘pipe_reader::result pipe_reader::read(std::vector<char>&,
std::chrono::milliseconds)’:
./linuxdeploy/src/subprocess/pipe_reader.cpp:59:1: warning: control
reaches end of non-void function [-Wreturn-type]
|
|
namespace fs = std::filesystem;
|
|
|
|
|
|
namespace {
|
|
|
namespace private_items {
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change makes no sense in this context. I need to think about this...
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.