GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix rpath for libraries in subfolders of usr/lib and for executables in usr/lib/libexec by ingokloecker · Pull Request #233 · linuxdeploy/linuxdeploy

Conversation

@ingokloecker

@ingokloecker ingokloecker commented Nov 15, 2022

Copy link
Copy Markdown

This is an attempt to make the rpaths of ELF files in subfolders of usr/lib more correct (if I understand rpath correctly).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ingokloecker added 5 commits November 15, 2022 16:39
@ingokloecker
Avoid $ORIGIN/.:$ORIGIN as result of calculateRelativeRPath
2d1f838
@ingokloecker
Allow callers to disable appending of :$ORIGIN to relative rpath
5aad589
@ingokloecker
Add the correct rpath for libraries in subfolders of usr/lib
790a3c2 
The rpath of libraries in subfolders of usr/lib should be
$ORIGIN/<location of usr/lib relative to the dirname of the library>
instead of just $ORIGIN, e.g. for usr/lib/sasl2/libscram.so.3.0.0 it
should be $ORIGIN/..
@ingokloecker
Add support for executables in usr/lib/libexec
68c3744
@ingokloecker
Add missing includes
fd95d72 
gcc 12 requires explicitly including <array> when using std::array.
@ingokloecker

ingokloecker commented Nov 15, 2022

Copy link
Copy Markdown
Author

Additionally, I'm wondering why linuxdeploy sets the rpath to $ORIGIN for deployed dependencies and for existing executables, but appends the calculated rpath to the existing rpaths for libraries already existing in the AppDir. My guess would be that the rpaths of existing libraries is not overwritten to avoid breaking some dependencies. Is this correct?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@ingokloecker
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.