GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add automatic excludelist updating at runtime and ignore-excludelist CLI option by Korne127 · Pull Request #287 · linuxdeploy/linuxdeploy

Conversation

@Korne127

@Korne127 Korne127 commented Jul 25, 2024

Copy link
Copy Markdown

This pull request adds an automatic excludelist updating mechanism at runtime.

With this pull request, each time the linuxdeploy command is invoked, it will try to download the current version of the excludelist, parse it and save it as a vector. If any of these steps fail, a warning is emitted.
For each library that should be tested against the excludelist, the newly downloaded excludelist will be used if it has been saved correctly, and the pre-packaged excludelist otherwise.

This feature is added because of the reasons stated in #286: Currently, it requires a new linuxdeploy version to be shipped and downloaded / used by everyone in order for excludelist changes to take effect. This also means that updates have to "trickle down" (e.g. when someone uses a framework like tauri that itself uses linuxdeploy) and it creates a single point of failure (a possible missing new linuxdeploy version).

This fixes #286.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Samueru-sama reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Korne127 added 2 commits July 25, 2024 02:10
@Korne127
Added automatic excludelist updating at runtime
c15d2e9
An automatic excludelist updating mechanism has been added at runtime.

To do this, each time the linuxdeploy command is invoked, it now tries to download the current version of the excludelist, parses it and saves it as a vector. If any of these steps fail, a warning is emitted.

For each library that should be tested against the excludelist, the newly downloaded excludelist is now used if it has been saved correctly, and the pre-packaged excludelist otherwise.

This feature has been added as previously, it had required a new linuxdeploy version to be shipped and downloaded / used by everyone in order for excludelist changes to take effect. This also meant that updates had to "trickle down" (e.g. when someone uses a framework like tauri that itself uses linuxdeploy) and it created a single point of failure (a possible missing new linuxdeploy version).
@Korne127
Added CLI option to ignore the excludelist
ec55d65
A new CLI option (--ignore-excludelist) has been added to linuxdeploy. When using it, the excludelist of the core libraries is ignored and the core libraries that are depended upon are included in the AppDir.
The excludelist updating will only take place if this option is not set (as it's not necessary otherwise).

Additionally, the code quality has been improved.
@Korne127 Korne127 changed the title Add automatic excludelist updating at runtime Add automatic excludelist updating at runtime and ignore-excludelist CLI flag Aug 24, 2024
@Korne127

Korne127 commented Aug 24, 2024

Copy link
Copy Markdown
Author

I just updated this to also add an ignore-excludelist CLI option (which will, if used, lead to core libraries that are depended upon being included in the AppDir). The excludelist updating will only take place if this option is not set (as its not necessary if it's set).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Korne127 Korne127 changed the title Add automatic excludelist updating at runtime and ignore-excludelist CLI flag Add automatic excludelist updating at runtime and ignore-excludelist CLI option Aug 24, 2024
@Korne127

Korne127 commented Dec 5, 2024

Copy link
Copy Markdown
Author

@TheAssassin Do you think this can be merged or do you want som changes? I think that especially the ignore-excludelist parameter is really useful for specific purposes in which you might want to do that so you don't have to combine linuxdeploy with other tools like go-appimage.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Excludelist doesn't automatically update during runtime

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@Korne127
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.