GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: dpkg find copyright by bmsuseluda · Pull Request #302 · linuxdeploy/linuxdeploy

Conversation

@bmsuseluda

@bmsuseluda bmsuseluda commented Dec 13, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Hello together,

after experiencing similar things as described in #270 i found out, that dpkg-query does not reliably find something by an absolute path. Therefore i only use the filename from the canonicalized path which should result in finding more copyright files.

i hope my changes are fine in the way i did them.
Please let me know if there is something i need to change.

thank you

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
bmsuseluda and others added 2 commits December 13, 2024 16:51
@bmsuseluda
fix: dpkg find copyright
f7f3fb8
@bmsuseluda
Merge branch 'master' into fix/dpkgFindCopyright
c207969
@bmsuseluda

bmsuseluda commented Feb 10, 2025

Copy link
Copy Markdown
Author

@TheAssassin Is there something i can do to bring this further?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bmsuseluda
Merge branch 'master' into fix/dpkgFindCopyright
1f7c775
@TheAssassin

TheAssassin commented Feb 13, 2025

Copy link
Copy Markdown
Member

This potentially copies many unrelated files into the AppDir. I don't see an improvement in this approach.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bmsuseluda

bmsuseluda commented Feb 14, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Author

Without it linuxdeploy throws about 100 warnings in my build, that copyright files can not be found. You can see it here: https://github.com/bmsuseluda/ares-emu-appimage/actions/runs/13240659936/job/36955122575#step:8:954

And this is because of the absolute path that is used right now. I looked on the system and dpkg can find the copyright files, but not reliably with this absolute path. With just the filename dpkg finds the correct copyright as you can see here: https://github.com/bmsuseluda/ares-emu-appimage/actions/runs/13161636934/job/36731614392#step:8:1

The filesize between these 2 is nearly the same, so i do not see a problem with unrelated files.
Please let me know if i overlook something here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@bmsuseluda @TheAssassin
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.