GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||
GeezerVison is showing github.com — Fix NullPointerException in `MethodsFunctionsChecker` by rcosta358 · Pull Request #150 · liquid-java/liquidjava Conversation
Collaborator
This PR fixes an issue where when a class had multiple methods and one method would throw an error related to a parametric refinement (e.g., Example Reproductionpublic class SimpleTest { void testParam(@Refinement("y + 1") int y) {} int test() { return -1; } } // Cannot invoke "liquidjava.processor.context.RefinedFunction.getArguments()" because "fi" is null
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
rcosta358
commented
Comment on lines
+184
to
+185
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just in case.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
rcosta358
commented
Comment on lines
-414
to
-417
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We cannot assume this anymore because a method that throws
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
CatarinaGamboa
approved these changes
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nice fix! I dont even know why we had the
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Uh oh!
There was an error while loading. Please reload this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesLabels
bug
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | ||||||||||||||||||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |