GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add -a/--all flag to show all SMT verification conditions by CatarinaGamboa · Pull Request #243 · liquid-java/liquidjava

Conversation

@CatarinaGamboa

@CatarinaGamboa CatarinaGamboa commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

Description

Closes #240

Now we show all the VCs that were sent to the smt solver even if there are no errors.

Example

Screenshot 2026-06-02 at 3 56 03 PM

Type of change

  • Bug fix
  • New feature
  • Documentation update
  • Code refactoring

Checklist

  • Added/updated tests under liquidjava-example/src/main/java/testSuite/ (Correct* / Error*)
  • mvn test passes locally
  • Updated docs/README if behavior or API changed

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@CatarinaGamboa
CatarinaGamboa requested a review from rcosta358 June 2, 2026 15:34
rcosta358
rcosta358 approved these changes Jun 2, 2026
View reviewed changes
Comment thread liquidjava-verifier/src/main/java/liquidjava/api/CommandLineArgs.java Outdated
public boolean debugMode;

@Option(names = { "-a", "--all" }, description = "Show every verification condition sent to the SMT solver")
public boolean showAllVCs;

@rcosta358 rcosta358 Jun 2, 2026

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe rename to something like debugAllMode.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread liquidjava-verifier/src/main/java/liquidjava/diagnostics/DebugLog.java Outdated
* {@code --debug} / {@code -d} or the lighter {@code --all} / {@code -a}, which shows every query without the rest
* of the debug output (e.g. simplification passes).
*/
public static boolean smtEnabled() {

@rcosta358 rcosta358 Jun 2, 2026

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe rename to loggingEnabled.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@CatarinaGamboa
CatarinaGamboa marked this pull request as draft June 3, 2026 14:19
@CatarinaGamboa

CatarinaGamboa commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator Author

We need more information for the cases we don't even have verification starting when there was supposed to be some, I'll work on this next
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@CatarinaGamboa
CatarinaGamboa force-pushed the worktree-issue-240 branch from f5b880e to 380a89d Compare June 13, 2026 17:14
CatarinaGamboa added 2 commits June 13, 2026 19:14
@CatarinaGamboa
Change flag to dump context info
a684f45
@CatarinaGamboa
Flag all shows both context and the debug info
baefe3d
@CatarinaGamboa
CatarinaGamboa force-pushed the worktree-issue-240 branch from 380a89d to baefe3d Compare June 13, 2026 17:14
@CatarinaGamboa
less changes in utils
e593f79
@rcosta358
rcosta358 force-pushed the main branch from 215f1d4 to d91f256 Compare July 27, 2026 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rcosta358 rcosta358 rcosta358 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add a flag -a to show all verification conditions sent to the smt solver

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@CatarinaGamboa @rcosta358
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.