GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Improve Test Suite by rcosta358 · Pull Request #293 · liquid-java/liquidjava

Conversation

@rcosta358

@rcosta358 rcosta358 commented Sep 12, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Description

Closes #196, #197, #198, and #174.

  • Added inline expectations for both errors and warnings using // Expect: ...
  • Made so every reported diagnostic must have a matching expectation, and every expectation must be reported
  • Removed pass/fail decisions based on file or directory names
  • Simplified test discovery by running Java files individually and leaf directories as grouped tests

Related Issues

#196, #197, #198, and #174.

Type of change

  • Bug fix
  • New feature
  • Documentation update
  • Code refactoring

Checklist

  • Added/updated tests under liquidjava-example/src/main/java/testSuite/
  • ./mvnw test passes locally
  • Updated docs/README if behavior or API changed

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
rcosta358 added 5 commits September 12, 2026 23:50
@rcosta358
Inline Expected Warnings in Tests
66952cc
@rcosta358
Code Refactoring
798f6f9
@rcosta358
Update Javadocs
097591f
@rcosta358
Improve Expected Pattern in Tests
ffef6f5
@rcosta358
Diagnostic Based Test Results
97a83d7
@rcosta358 rcosta358 self-assigned this Sep 12, 2026
@rcosta358 rcosta358 added the tests Related to tests label Sep 12, 2026
This was linked to issues Sep 12, 2026
Diagnostic Based Test Results #197
Closed
Improve Expected Pattern in Tests #198
Closed
rcosta358 added 3 commits September 13, 2026 00:02
@rcosta358
Update README
a52ec32
@rcosta358
Improve Test Directory
20885c9
@rcosta358
Code Refactoring
d8c7897
@rcosta358 rcosta358 linked an issue Sep 12, 2026 that may be closed by this pull request
Improve Test Suite #174
Closed
@rcosta358 rcosta358 changed the title Improve Tests Improve Test Suite Sep 13, 2026
@rcosta358
rcosta358 requested a review from CatarinaGamboa September 20, 2026 14:09
CatarinaGamboa
CatarinaGamboa approved these changes Sep 30, 2026
View reviewed changes

@CatarinaGamboa CatarinaGamboa left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit for future

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
rcosta358 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Comment thread liquidjava-example/src/main/java/testSuite/math/errorAbs/MathRefinements.java

@Refinement("(arg0 > 0)?( _ == arg0):(_ == -arg0)")
public int abs(long arg0);
public int abs(long arg0); // Expect: Warning

@CatarinaGamboa CatarinaGamboa Sep 30, 2026

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the future we can also say what type of warning or part of the message or smt to be more accurate

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@rcosta358 rcosta358 Sep 30, 2026

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, it currently is like that because all warnings share that same title for simplicity.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@rcosta358
rcosta358 merged commit 51ad687 into main Sep 30, 2026
1 check passed

Uh oh!

There was an error while loading. Please reload this page.
@CatarinaGamboa CatarinaGamboa mentioned this pull request Oct 2, 2026
Soundness: short-circuit RHS assignments are treated as executed #323
Open
@rcosta358
rcosta358 deleted the improve-tests branch October 13, 2026 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CatarinaGamboa CatarinaGamboa CatarinaGamboa approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@rcosta358 rcosta358

Labels

tests Related to tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve Expected Pattern in Tests Diagnostic Based Test Results Inline Expected Warnings in Tests Improve Test Suite

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@rcosta358 @CatarinaGamboa
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.