GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — Reject stale refinements after short-circuit RHS writes by CatarinaGamboa · Pull Request #324 · liquid-java/liquidjava Conversation
Collaborator
DescriptionThe verifier scanned the right operand of This ports the paired reproducer and fix from closed #257 to current Exampleint x = 0; boolean ignored = false && ((x = 1) == 1); @Refinement("_ == 1") int y = x; // Expect: Refinement Error On This is conservative: it forgets a RHS write even when the left operand happens to force the RHS to run, so some safe code may need a more precise future path merge to verify. Related IssueFixes #323. Based on Type of change
Checklist
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsPort the short-circuit soundness fix and reproducer from closed PR #257 to current main. Add coverage for OR, nested assignments, increments, and an RHS without writes. Fixes #323 Co-authored-by: Guilherme Espada <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersNo reviewsUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Soundness: short-circuit RHS assignments are treated as executedUh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |