GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Reject stale refinements after short-circuit RHS writes by CatarinaGamboa · Pull Request #324 · liquid-java/liquidjava

Conversation

@CatarinaGamboa

@CatarinaGamboa CatarinaGamboa commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator

Description

The verifier scanned the right operand of && and || as though it always ran. A write there could then be trusted after Java had skipped it. After checking the operator, this change gives each variable written in its right operand a fresh unconstrained value, so a refinement cannot rely on the skipped assignment.

This ports the paired reproducer and fix from closed #257 to current main. The test uses the current // Expect: convention and adds ||, nested assignments, increment, and a right operand without writes.

Example

int x = 0;
boolean ignored = false && ((x = 1) == 1);
@Refinement("_ == 1") int y = x; // Expect: Refinement Error

On main at dd02e996, the verifier accepts the expanded test file. This branch reports four expected refinement errors; the no-write case still passes. The original example fails its Java assertion when run with -ea.

This is conservative: it forgets a RHS write even when the left operand happens to force the RHS to run, so some safe code may need a more precise future path merge to verify.

Related Issue

Fixes #323. Based on 5d3f1c29 and c23f819d from #257; Guilherme Espada is credited in the commit.

Type of change

  • Bug fix
  • New feature
  • Documentation update
  • Code refactoring

Checklist

  • Added tests under liquidjava-example/src/main/java/testSuite/
  • mvn test passes locally
  • Updated docs/README if behavior or API changed (not applicable)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@CatarinaGamboa @GUIpsp
Reject stale refinements after short-circuit RHS writes
e8cf402
Port the short-circuit soundness fix and reproducer from closed PR #257 to current main. Add coverage for OR, nested assignments, increments, and an RHS without writes.

Fixes #323

Co-authored-by: Guilherme Espada <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Soundness: short-circuit RHS assignments are treated as executed

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@CatarinaGamboa
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.