GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fade dimmed diagram parts less in light themes and count errors on Verification by CatarinaGamboa · Pull Request #166 · liquid-java/vscode-liquidjava

Conversation

@CatarinaGamboa

@CatarinaGamboa CatarinaGamboa commented Oct 26, 2026

Copy link
Copy Markdown
Collaborator

Description

Built on #165, so until #165 is merged this PR also shows its two commits; only the last commit is new. It targets main so it cannot be stranded on the #165 branch.

  • Dimmed parts in light themes. Dimmed states, transitions, and methods had opacity: 0.25, which on white left the method names barely readable. The opacity is now --lj-dimmed-opacity: 0.25 as before, and 0.5 in light themes. Dark themes are unchanged.
  • Error count on Verification. The Verification tab shows the number of errors in the current file, the same number as Current file in its header, in the red badge. So that the two badges do not compete, the State Machine badge now uses VS Code's neutral badge colour: its state errors are already among the errors counted on Verification. Both counts stay up to date while the State Machine tab is open.

Screenshots

The UDP chat client with three state errors (receive after a possible close, bind on a bound socket, connect after close), so both badges show.

Light theme, before and after

Light theme before: dimmed methods barely readable Light theme after: dimmed methods readable, Verification badge red and State Machine badge neutral

The badges, light and dark

Light theme Verification tab with both badges

Dark theme Verification tab with both badges

Dark theme, after (the dimming is unchanged)

Dark theme state machine

Tests

  • npm run lint and npm run test:typecheck: clean.
  • npm run test:unit: 99 passed. New tests:
    • script.spec.ts: the Verification badge counts the current file's errors in red, the State Machine badge is neutral, and both update on the State Machine tab and disappear when the errors are fixed;
    • styles.spec.ts: the dimmed opacity is 0.25, and 0.5 in light themes.
  • npm test (VS Code): 9 + 1 passing. Server mvn test and the local smoke test: passed.

🤖 Generated with Claude Code

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@CatarinaGamboa
CatarinaGamboa force-pushed the feat/light-dim-and-verification-badge branch from 3949519 to f0390a9 Compare October 26, 2026 14:48
@CatarinaGamboa @claude
Fade dimmed diagram parts less in light themes and count errors on Ve…
9df4844
…rification

Dimmed states and methods were barely readable on white, so light themes use a
higher opacity. The Verification tab shows the number of errors in the current
file in red, and the State Machine tab shows its state errors in the neutral
badge colour, since Verification already counts them.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@CatarinaGamboa
CatarinaGamboa force-pushed the feat/light-dim-and-verification-badge branch from f0390a9 to 9df4844 Compare October 26, 2026 15:44
@CatarinaGamboa
CatarinaGamboa merged commit 9e15d24 into main Oct 26, 2026
3 checks passed

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@CatarinaGamboa
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.