GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Backwards compatibility by ghostal · Pull Request #1 · littlebizzy/force-https

Conversation

@ghostal

@ghostal ghostal commented May 18, 2018

Copy link
Copy Markdown

Thanks for your work on this plugin!

With the most recent update, the short syntax for PHP arrays breaks PHP 5 installs. These changes fix it again.

Dropping support for PHP 5 at this stage is pretty reasonable, but I'd suggest bumping the major version if the plan is to no longer support it, as it's a breaking change for sites still running on PHP 5.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ghostal added 2 commits May 18, 2018 10:53
@ghostal
Backwards compatibility
26007f4
@ghostal
Backwards compatibility
9034188
@jessuppi

jessuppi commented May 20, 2018

Copy link
Copy Markdown
Member

Thanks for the feedback Alex, however, our plugins have never claimed to support anything other than PHP version 7.0 (any other compatibility is simply coincidental).

We follow WordPress version/branches so don't have a good way to merge pull requests yet.

However we will review this for next version.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ghostal @jessuppi
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.