GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Make it an error to have ambiguous overloads in handler groups · livecode/livecode@f471f10

This repository was archived by the owner on Aug 31, 2021. It is now read-only.

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

libscript/src
- script-bytecode.hpp

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎libscript/src/script-bytecode.hpp‎`

Copy file name to clipboardExpand all lines: libscript/src/script-bytecode.hpp

+15-5Lines changed: 15 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -357,12 +357,14 @@ struct MCScriptBytecodeOp_Invoke`
`357`	`357`	`// We use a simple scoring mechanism to determine which method to use. If`
`358`	`358`	`// input type for an argument is equal to expected type, then this is a`
`359`	`359`	`// score of zero. If input type for an argument conforms to expected type, then`
`360`		`- // this is a score of 1. The method with the lowest score is chosen, with`
`361`		`- // priority given to the first in the list in the case of a tie.`
	`360`	`+ // this is a score of 1. The method with the lowest score is chosen`
	`361`	`+ // unless multiple variants have the same score, which is an error.`
`362`	`362`
`363`	`363`	`uindex_t t_min_score = UINDEX_MAX;`
`364`	`364`	`MCScriptDefinition *t_min_score_definition = nil;`
`365`	`365`	`MCScriptInstanceRef t_min_score_instance = nil;`
	`366`	`+ bool t_min_score_ambiguous = false;`
	`367`	`+`
`366`	`368`	`for(uindex_t t_handler_idx = 0; t_handler_idx < p_group -> handler_count; t_handler_idx++)`
`367`	`369`	`{`
`368`	`370`	`MCScriptInstanceRef t_current_instance;`
`@@ -419,14 +421,22 @@ struct MCScriptBytecodeOp_Invoke`
`419`	`421`	`t_current_score += 1;`
`420`	`422`	`}`
`421`	`423`
`422`		`- if (t_current_score < t_min_score)`
	`424`	`+ if (t_current_score == t_min_score)`
	`425`	`+ {`
	`426`	`+ // The minimum score is ambiguous - multiple alternatives have`
	`427`	`+ // equal scores.`
	`428`	`+ t_min_score_ambiguous = true;`
	`429`	`+ }`
	`430`	`+ else if (t_current_score < t_min_score)`
`423`	`431`	`{`
`424`		`- t_min_score = t_current_score;`
	`432`	`+ // A new minimum score has been found`
	`433`	`+ t_min_score = t_current_score;`
`425`	`434`	`t_min_score_definition = t_current_definition;`
`426`	`435`	`t_min_score_instance = t_current_instance;`
	`436`	`+ t_min_score_ambiguous = false;`
`427`	`437`	`}`
`428`	`438`	`}`
`429`		`- if (t_min_score_definition == NULL)`
	`439`	`+ if (t_min_score_ambiguous \|\| t_min_score_definition == NULL)`
`430`	`440`	`{`
`431`	`441`	`ctxt.ThrowUnableToResolveMultiInvoke(p_group,`
`432`	`442`	`p_arguments,`

0 commit comments

Comments

0 (0)

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.