GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Support User Defined PooledByteBufAllocator by Maithem · Pull Request #162 · lmdbjava/lmdbjava

Conversation

Maithem commented Aug 18, 2020

Copy link

Copy Markdown

Contributor

This patch allows users to pass a PooledByteBufAllocator instance
if they wish to not use the DEFAULT instance. Also, this patch
fixes a minor bug where a ByteBuf is created during initialization
without ever being released.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Support User Defined PooledByteBufAllocator

cb19f59

This patch allows users to pass a PooledByteBufAllocator instance
if they wish to not use the DEFAULT instance. Also, this patch
fixes a minor bug where a ByteBuf is created during initialization
without ever being released.

codecov-commenter commented Aug 18, 2020

Copy link

Copy Markdown

Codecov Report

Merging #162 into master will increase coverage by 0.12%.
The diff coverage is 92.30%.

@@             Coverage Diff              @@
##             master     #162      +/-   ##
============================================
+ Coverage     90.93%   91.06%   +0.12%     
+ Complexity      383      382       -1     
============================================
  Files            30       30              
  Lines          1346     1343       -3     
  Branches        118      116       -2     
============================================
- Hits           1224     1223       -1     
  Misses           58       58              
+ Partials         64       62       -2

Impacted Files	Coverage Δ	Complexity Δ
src/main/java/org/lmdbjava/ByteBufProxy.java	`81.13% <92.30%> (+2.56%)`	`11.00 <3.00> (-1.00)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26d76be...cb19f59. Read the comment docs.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bp-alex merged commit 3a0a702 into lmdbjava:master

Oct 24, 2020

bp-alex commented Oct 24, 2020

Copy link

Copy Markdown

Member

Thank you @Maithem.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Maithem deleted the pooledAllocator branch

January 20, 2021 00:37

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.