GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Define manifest attribute Automatic-Module-Name by pedrolamarao · Pull Request #213 · lmdbjava/lmdbjava

Conversation

@pedrolamarao

@pedrolamarao pedrolamarao commented Feb 28, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This change defines the manifest attribute Automatic-Module-Name, transforming the JAR into an automatic module with module name org.lmdbjava. This should be enough for other Java modules to be able to reference this. I have verified that this is the case by installing it to a local repository and referencing it from my own projects.

Please note that doing this has no impact on non modular applications, which will simply ignore the attribute, both on older and newer JDKs. This change is an easy first step towards module support.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Pedro Lamarão
Define manifest attribute Automatic-Module-Name.
f372d18
@pedrolamarao pedrolamarao changed the title Define manifest attribute Automatic-Module-Name. Define manifest attribute Automatic-Module-Name Feb 28, 2023
@pedrolamarao

pedrolamarao commented Feb 28, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Please consider this PR in the context of #42 and #208
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bp-alex
bp-alex merged commit 860c827 into lmdbjava:master Mar 9, 2023
@bp-alex

bp-alex commented Mar 9, 2023

Copy link
Copy Markdown
Member

Thanks @pedrolamarao
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bp-alex bp-alex mentioned this pull request Apr 24, 2023
Compatibility with Java 19 - Modularize? Minimizing use of unsupported JDK parts? #208
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@pedrolamarao @bp-alex
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.