GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Regression: Add DbiFlags#MDB_UNSIGNEDKEY to allow to compare byte array, ByteBuffer and DirectBuffer keys as unsigned like in versions prior to 0.9.0 by cdprete · Pull Request #237 · lmdbjava/lmdbjava

Conversation

@cdprete

@cdprete cdprete commented Mar 6, 2024

Copy link
Copy Markdown
Contributor

Fixes #228 and #230.

I was not able to run the tests locally on Windows (I'm getting a NoClassDefFoundError kind of everywhere), so I hope I didn't break any.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
This was referenced Mar 6, 2024
LMDB errors 7.3 gchq/stroom#4133
Open
ByteBuffer sorting changed in 0.9.0 #230
Closed
CursorIterable/KeyRange broken in v0.9.0 #228
Closed
@cdprete

cdprete commented Mar 9, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

@benalexau A test for this was done in #230 (comment)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Cosimo Damiano Prete
Regression: Add DbiFlags#MDB_UNSIGNEDKEY to allow to compare byte arr…
1fc58e8 
…ay, ByteBuffer and DirectBuffer keys as unsigned like in versions prior to 0.9.0
@at055612

at055612 commented Feb 4, 2025

Copy link
Copy Markdown
Collaborator

This PR will need the changes to the github actions workflow file maven.yml as seen in here https://github.com/lmdbjava/lmdbjava/pull/235/files. The old v3 actions will fail the CI build.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cdprete

cdprete commented Feb 4, 2025 via email

Copy link
Copy Markdown
Contributor Author
I can pull such changes in without any issue once they get merged. But, I'm honestly starting to doubt if the project is still maintained in the first place. Il mar 4 feb 2025, 14:11 at055612 ***@***.***> ha scritto:
…
This PR will need the changes to the github actions workflow file maven.yml as seen in here https://github.com/lmdbjava/lmdbjava/pull/235/files. The old v3 actions will fail the CI build. — Reply to this email directly, view it on GitHub <#237 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACAZGWEYULCGS5PLW6T3LGL2OC37XAVCNFSM6AAAAABWORHLZGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMZTHA3DEMBTGA> . You are receiving this because you authored the thread.Message ID: ***@***.***>
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@at055612

at055612 commented Feb 4, 2025

Copy link
Copy Markdown
Collaborator

But, I'm honestly starting to doubt if the project is still maintained in the first place.

I've contacted the maintainer (@benalexau) in the hope that the outstanding PRs can be addressed, merged and released. 🤞
cdprete reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bp-alex
bp-alex merged commit 68f0a44 into lmdbjava:master Feb 16, 2025
@cdprete
cdprete deleted the fix/unsigned-compare branch February 18, 2025 19:38
@at055612 at055612 mentioned this pull request Mar 5, 2025
The new MDB_UNSIGNEDKEY DbiFlag should probably be the default behaviour #249
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CursorIterable/KeyRange broken in v0.9.0

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@cdprete @at055612 @bp-alex
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.