GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — CFN: add validation to FnSplit by pinzon · Pull Request #13244 · localstack/localstack

This repository was archived by the owner on Mar 23, 2026. It is now read-only.

Conversation

@pinzon

@pinzon pinzon commented Oct 8, 2025 •
edited by simonrw
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Motivation

This PR adds a validation to the arguments passed to Fn::Split. Some customers are finding the new CFn engine hard to use due to the lack of proper validation error messages.

Example:

!Split [!Ref TemplateParameter]

Should be used like:

!Split ["-", !Ref TemplateParameter]

Changes

  • Add validation when evaluating Fn:Split

Testing

  • AWS Validated test

Notes

related to #13217

Part of UNC-31

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pinzon pinzon added aws:cloudformation AWS CloudFormation semver: patch Non-breaking changes which can be included in patch releases aws:cloudformation:v2 Issues related to the V2 CloudFormation engine docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Oct 8, 2025
@github-actions

github-actions Bot commented Oct 8, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Test Results - Preflight, Unit

22 298 tests  ±0   20 555 ✅ ±0   16m 24s ⏱️ +3s
     1 suites ±0    1 743 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit fecdf0f. ± Comparison against base commit 69ed784.

♻️ This comment has been updated with latest results.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Oct 8, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

LocalStack Community integration with Pro

  2 files    2 suites   36m 3s ⏱️
585 tests 471 ✅ 114 💤 0 ❌
587 runs  471 ✅ 116 💤 0 ❌

Results for commit fecdf0f.

♻️ This comment has been updated with latest results.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Oct 8, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 21s ⏱️ +2s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit fecdf0f. ± Comparison against base commit 69ed784.

♻️ This comment has been updated with latest results.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Oct 8, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Test Results (amd64) - Integration, Bootstrap

  5 files    5 suites   48m 33s ⏱️
609 tests 496 ✅ 113 💤 0 ❌
615 runs  496 ✅ 119 💤 0 ❌

Results for commit fecdf0f.

♻️ This comment has been updated with latest results.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Oct 8, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Test Results - Alternative Providers

584 tests   330 ✅  25m 48s ⏱️
  1 suites  254 💤
  1 files      0 ❌

Results for commit fecdf0f.

♻️ This comment has been updated with latest results.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pinzon pinzon added this to the Playground milestone Oct 8, 2025
@pinzon
pinzon marked this pull request as ready for review October 9, 2025 01:34
@pinzon
pinzon requested review from dominikschubert and simonrw as code owners October 9, 2025 01:34
@simonrw simonrw mentioned this pull request Oct 10, 2025
CFN: add more validations to intrinsic FnEquals #13217
Merged
pinzon added 2 commits October 10, 2025 12:31
@pinzon
CFN: add validation to FnSplit
d0ee08b
@pinzon
skip for v1 and improve condition
fecdf0f
@pinzon
pinzon force-pushed the cp/cfn/v2/validate-split branch from 46fc152 to fecdf0f Compare October 10, 2025 17:31
@pinzon pinzon added the review: merge when ready Signals to the reviewer that a PR can be merged if accepted label Oct 10, 2025
simonrw
simonrw approved these changes Oct 13, 2025
View reviewed changes
@pinzon
pinzon merged commit ab567e5 into main Oct 13, 2025
@pinzon
pinzon deleted the cp/cfn/v2/validate-split branch October 13, 2025 19:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner
1 more reviewer
@simonrw simonrw simonrw approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

aws:cloudformation:v2 Issues related to the V2 CloudFormation engine aws:cloudformation AWS CloudFormation docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes review: merge when ready Signals to the reviewer that a PR can be merged if accepted semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

Playground

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@pinzon @simonrw
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.