GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — S3: clean up leftover legacy code by bentsku · Pull Request #13271 · localstack/localstack

This repository was archived by the owner on Mar 23, 2026. It is now read-only.

Conversation

@bentsku

@bentsku bentsku commented Oct 14, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Motivation

While working on #13250, I noticed some legacy code that isn't used anymore and is a remnant that wasn't cleaned up when removing the legacy S3 provider (in #11746)

This PR cleans up a bit 🧹

Changes

  • clean up and remove legacy code related to removed Virtual Host proxying logic
  • rename a method to not talk about "native" anymore which was used to make a distinction between pure LocalStack implement vs Moto

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bentsku
clean up S3
61c9aca
@bentsku bentsku added this to the 4.10 milestone Oct 14, 2025
@bentsku bentsku self-assigned this Oct 14, 2025
@bentsku bentsku added aws:s3 Amazon Simple Storage Service semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Oct 14, 2025
@github-actions

github-actions Bot commented Oct 14, 2025

Copy link
Copy Markdown

S3 Image Test Results (AMD64 / ARM64)

    2 files    2 suites   8m 15s ⏱️
  533 tests 481 ✅  52 💤 0 ❌
1 066 runs  962 ✅ 104 💤 0 ❌

Results for commit 61c9aca.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Oct 14, 2025

Copy link
Copy Markdown

Test Results - Preflight, Unit

22 337 tests  ±0   20 587 ✅ ±0   16m 7s ⏱️ -1s
     1 suites ±0    1 750 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 61c9aca. ± Comparison against base commit 395f363.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Oct 14, 2025

Copy link
Copy Markdown

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 28s ⏱️ +9s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 61c9aca. ± Comparison against base commit 395f363.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Oct 14, 2025

Copy link
Copy Markdown

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   1h 41m 26s ⏱️
2 001 tests 1 835 ✅ 166 💤 0 ❌
2 007 runs  1 835 ✅ 172 💤 0 ❌

Results for commit 61c9aca.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Oct 14, 2025

Copy link
Copy Markdown

LocalStack Community integration with Pro

    2 files      2 suites   1h 18m 54s ⏱️
1 977 tests 1 807 ✅ 170 💤 0 ❌
1 979 runs  1 807 ✅ 172 💤 0 ❌

Results for commit 61c9aca.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bentsku
bentsku marked this pull request as ready for review October 15, 2025 09:29
@bentsku
bentsku requested a review from k-a-il as a code owner October 15, 2025 09:29
k-a-il
k-a-il approved these changes Oct 16, 2025
View reviewed changes

@k-a-il k-a-il left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bentsku
bentsku merged commit cc8cc23 into main Oct 16, 2025
@bentsku
bentsku deleted the s3-clean-up branch October 16, 2025 16:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@k-a-il k-a-il k-a-il approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@bentsku bentsku

Labels

aws:s3 Amazon Simple Storage Service docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

4.10

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@bentsku @k-a-il
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.