GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Change one of the test domains for the DNS tests by dfangl · Pull Request #13333 · localstack/localstack

This repository was archived by the owner on Mar 23, 2026. It is now read-only.

Conversation

@dfangl

@dfangl dfangl commented Nov 4, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Motivation

Recent test failures showed the foo.something.org domain we used for testing resolving to an unexpected IP address. It seems the domain owner, a domain reseller, started resolving this domain to some IP.

Even though this seems to have changed again since, we should not take the risk in the future.

Fixes ENG-104

Changes

  • Change something.org to example.org in tests querying the name servers of a domain.

Tests

Related

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@dfangl
Change test domains directly querying something.org
6515127
@dfangl dfangl added semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Nov 4, 2025
@dfangl
dfangl requested a review from simonrw November 4, 2025 09:51
@github-actions

github-actions Bot commented Nov 4, 2025

Copy link
Copy Markdown

LocalStack Community integration with Pro

2 files  ±    0  2 suites  ±0   33s ⏱️ - 1h 58m 33s
2 tests  - 4 892  0 ✅  - 4 524  2 💤  - 367  0 ❌  - 1 
4 runs   - 4 892  0 ✅  - 4 524  4 💤  - 367  0 ❌  - 1 

Results for commit 6515127. ± Comparison against base commit 4952b82.

This pull request removes 4892 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Nov 4, 2025

Copy link
Copy Markdown

Test Results - Preflight, Unit

22 278 tests  ±0   20 526 ✅ +1   16m 5s ⏱️ +42s
     1 suites ±0    1 752 💤 ±0 
     1 files   ±0        0 ❌  - 1 

Results for commit 6515127. ± Comparison against base commit 4952b82.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
simonrw
simonrw approved these changes Nov 4, 2025
View reviewed changes

@simonrw simonrw left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good idea, thanks. A ticking time bomb that went off!

There are other mentions of something.org in test_dns_server_soa_record_suffix_matching, is it worth changing those to use example.org as well?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@github-actions

github-actions Bot commented Nov 4, 2025

Copy link
Copy Markdown

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 21s ⏱️ -2s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 6515127. ± Comparison against base commit 4952b82.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Nov 4, 2025

Copy link
Copy Markdown

Test Results (amd64) - Integration, Bootstrap

 5 files   5 suites   9m 22s ⏱️
26 tests 24 ✅ 2 💤 0 ❌
32 runs  24 ✅ 8 💤 0 ❌

Results for commit 6515127.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dfangl

dfangl commented Nov 4, 2025

Copy link
Copy Markdown
Member Author

There are other mentions of something.org in test_dns_server_soa_record_suffix_matching, is it worth changing those to use example.org as well?

I saw those, but they are only the value of the SOA entry, not the name queried, so I did not change it. It should not come into contact with the something.org nameservers, so I think we should be safe 👍
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dfangl
dfangl merged commit 3262ccd into main Nov 4, 2025
56 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@dfangl
dfangl deleted the dns/change-test-domain branch November 4, 2025 10:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@simonrw simonrw simonrw approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@dfangl @simonrw
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.