GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — OpenSearch: Disable SSL validation for unsupported regions by dfangl · Pull Request #13346 · localstack/localstack

This repository was archived by the owner on Mar 23, 2026. It is now read-only.

Conversation

@dfangl

@dfangl dfangl commented Nov 6, 2025 •
edited by silv-io
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Motivation

With #13275, we generally enabled SSL certificate validation for our requests clients.
However, this leads to an issue with non-default-region tests (example), with regional endpoints for regions not present in our localhost.localstack.cloud certificates SAN list.

This leads to flakes in our pipeline, every time an ap-southeast-* region is used.

With this fix, we disable certificate validation only for opensearch and the regions not supported by the certificate.

Changes

  • Disable certificate validation for opensearch tests in regions not present in our certificate

Tests

  • Run test_opensearch.py using TEST_AWS_REGION_NAME=ap-northeast-1

Related

Fixes ENG-112
Fixes FLC-152

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@dfangl
OpenSearch: Disable SSL validation for unsupported regions
d085d56
@dfangl dfangl added semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Nov 6, 2025
@dfangl
dfangl requested review from alexrashed and silv-io as code owners November 6, 2025 11:31
@dfangl dfangl added semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Nov 6, 2025
@silv-io

silv-io commented Nov 6, 2025

Copy link
Copy Markdown
Member

Nice, this should also fix FLC-152
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Nov 6, 2025

Copy link
Copy Markdown

LocalStack Community integration with Pro

 2 files  ±    0   2 suites  ±0   9m 32s ⏱️ - 1h 51m 36s
48 tests  - 4 846  33 ✅  - 4 486  15 💤  - 354  0 ❌  - 6 
50 runs   - 4 846  33 ✅  - 4 486  17 💤  - 354  0 ❌  - 6 

Results for commit d085d56. ± Comparison against base commit 5f5a8fb.

This pull request removes 4846 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Nov 6, 2025

Copy link
Copy Markdown

Test Results - Preflight, Unit

22 278 tests  ±0   20 526 ✅ ±0   15m 23s ⏱️ -20s
     1 suites ±0    1 752 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit d085d56. ± Comparison against base commit 5f5a8fb.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Nov 6, 2025

Copy link
Copy Markdown

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 21s ⏱️ -1s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit d085d56. ± Comparison against base commit 5f5a8fb.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Nov 6, 2025

Copy link
Copy Markdown

Test Results (amd64) - Integration, Bootstrap

 5 files   5 suites   18m 53s ⏱️
72 tests 57 ✅ 15 💤 0 ❌
78 runs  57 ✅ 21 💤 0 ❌

Results for commit d085d56.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
alexrashed
alexrashed approved these changes Nov 6, 2025
View reviewed changes

@alexrashed alexrashed left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, great catch! I wonder if we can just disable the verification just generally for the opensearch tests?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@dfangl

dfangl commented Nov 6, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

I wonder if we can just disable the verification just generally for the opensearch tests?

We could, but then we don't test that the opensearch names are in the certificate at all. It should not spontaneously change, but I do not see a value in not testing it? Am I overlooking something here?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dfangl
dfangl merged commit a2d83bf into main Nov 6, 2025
68 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@dfangl
dfangl deleted the eng-112-opensearch-mamr-tests-fail-with-certificate-error branch November 6, 2025 12:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@silv-io silv-io Awaiting requested review from silv-io
1 more reviewer
@alexrashed alexrashed alexrashed approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@dfangl @silv-io @alexrashed
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.