GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — chore: define rest of explicit state containers for providers by bentsku · Pull Request #13433 · localstack/localstack

This repository was archived by the owner on Mar 23, 2026. It is now read-only.

Conversation

@bentsku

@bentsku bentsku commented Nov 27, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Motivation

Follow-up from #13423, this PR migrates the rest of the service providers to properly indicates which state container(s) they use.

It migrates the rest of the Community services.

Changes

Migrate the following services to be explicit about their state containers:

Service Store Backend
route53 X X
route53resolver X X
s3control - X
scheduler - X
secretsmanager - X
ses - X
sns v1 X X
sns v2 X -
sqs X -
ssm - X
sts X X
support - X
swf - X
transcribe X X

Tests

Full Pro run ✅: https://github.com/localstack/localstack-pro/actions/runs/19830037292

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bentsku bentsku added this to the 4.12 milestone Nov 27, 2025
@bentsku bentsku self-assigned this Nov 27, 2025
@bentsku bentsku added semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Nov 27, 2025
@github-actions

github-actions Bot commented Nov 27, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Test Results - Preflight, Unit

22 686 tests  ±0   20 918 ✅ ±0   6m 17s ⏱️ -2s
     1 suites ±0    1 768 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 11c7a5e. ± Comparison against base commit ff6e5e0.

♻️ This comment has been updated with latest results.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Nov 27, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Test Results (amd64) - Acceptance

7 tests   5 ✅  3m 23s ⏱️
1 suites  2 💤
1 files    0 ❌

Results for commit 11c7a5e.

♻️ This comment has been updated with latest results.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Nov 27, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   2h 13m 7s ⏱️
4 483 tests 4 167 ✅ 316 💤 0 ❌
4 489 runs  4 167 ✅ 322 💤 0 ❌

Results for commit 11c7a5e.

♻️ This comment has been updated with latest results.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Nov 27, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

LocalStack Community integration with Pro

    2 files      2 suites   1h 40m 33s ⏱️
4 459 tests 4 139 ✅ 320 💤 0 ❌
4 461 runs  4 139 ✅ 322 💤 0 ❌

Results for commit 11c7a5e.

♻️ This comment has been updated with latest results.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bentsku
bentsku force-pushed the explicit-visitor branch from 64d9a33 to bc73f29 Compare November 28, 2025 17:46
@bentsku
bentsku force-pushed the explicit-visitor-next branch 3 times, most recently from 6d04112 to 65231d0 Compare November 28, 2025 19:21
@bentsku
bentsku changed the base branch from explicit-visitor to main November 28, 2025 19:25
@bentsku
bentsku force-pushed the explicit-visitor-next branch from 65231d0 to 6e3e7f3 Compare December 1, 2025 16:34
bentsku added 15 commits December 1, 2025 18:33
@bentsku
define state container for route53
1852805
@bentsku
define state container for route53resolver
f2f88a1
@bentsku
define state container for s3control
006de83
@bentsku
define state container for scheduler
3d3dd21
@bentsku
define state container for secretsmanager
68be338
@bentsku
define state container for ses
c3f25c6
@bentsku
define state container for sns
360c0b6
@bentsku
define state container for sqs
d222422
@bentsku
define state container for ssm
4154048
@bentsku
define state container for sts
fbd6e2a
@bentsku
define state container for support
95d4370
@bentsku
define state container for swf
1136ecb
@bentsku
define state container for transcribe
524dc4b
@bentsku
fix linting mypy (only fails locally?)
3e1ff49
@bentsku
format the rebase
11c7a5e
@bentsku
bentsku force-pushed the explicit-visitor-next branch from 6e3e7f3 to 11c7a5e Compare December 1, 2025 17:33
@bentsku bentsku assigned giograno Dec 2, 2025
@bentsku
bentsku marked this pull request as ready for review December 2, 2025 12:35
@bentsku
bentsku requested review from baermat, dfangl, dominikschubert, giograno, gregfurman, macnev2013, pinzon, sannya-singal, thrau and viren-nadkarni as code owners December 2, 2025 12:35
giograno
giograno approved these changes Dec 2, 2025
View reviewed changes

@giograno giograno left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🧹

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bentsku
bentsku merged commit fd2d108 into main Dec 2, 2025
44 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bentsku
bentsku deleted the explicit-visitor-next branch December 2, 2025 15:01
@bentsku bentsku mentioned this pull request Dec 4, 2025
mypy: add moto-ext as additional-dependencies in pre-commit hook #13465
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sannya-singal sannya-singal Awaiting requested review from sannya-singal
@pinzon pinzon Awaiting requested review from pinzon
@dfangl dfangl Awaiting requested review from dfangl
@viren-nadkarni viren-nadkarni Awaiting requested review from viren-nadkarni
@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner
@thrau thrau Awaiting requested review from thrau
@baermat baermat Awaiting requested review from baermat
@gregfurman gregfurman Awaiting requested review from gregfurman
@macnev2013 macnev2013 Awaiting requested review from macnev2013
1 more reviewer
@giograno giograno giograno approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@giograno giograno

@bentsku bentsku

Labels

docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

4.12

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@bentsku @giograno
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.